Re: [PATCH 07/10] drm/tidss: Fix dss reset

2023-11-02 Thread Francesco Dolcini
On Wed, Nov 01, 2023 at 11:17:44AM +0200, Tomi Valkeinen wrote: > The probe function calls dispc_softreset() before runtime PM is enabled > and without enabling any of the DSS clocks. This happens to work by > luck, and we need to make sure the DSS HW is active and the fclk is > enabled. Not sure

Re: [PATCH 07/10] drm/tidss: Fix dss reset

2023-11-02 Thread Tomi Valkeinen
On 01/11/2023 16:30, Laurent Pinchart wrote: Hi Tomi, Thank you for the patch. On Wed, Nov 01, 2023 at 11:17:44AM +0200, Tomi Valkeinen wrote: The probe function calls dispc_softreset() before runtime PM is enabled and without enabling any of the DSS clocks. This happens to work by luck, and w

Re: [PATCH 07/10] drm/tidss: Fix dss reset

2023-11-01 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Wed, Nov 01, 2023 at 11:17:44AM +0200, Tomi Valkeinen wrote: > The probe function calls dispc_softreset() before runtime PM is enabled > and without enabling any of the DSS clocks. This happens to work by > luck, and we need to make sure the DSS HW is active a

[PATCH 07/10] drm/tidss: Fix dss reset

2023-11-01 Thread Tomi Valkeinen
The probe function calls dispc_softreset() before runtime PM is enabled and without enabling any of the DSS clocks. This happens to work by luck, and we need to make sure the DSS HW is active and the fclk is enabled. To fix the above, add a new function, dispc_init_hw(), which does: - pm_runtime_