Re: [PATCH 06/20] drm/msm: Use iommu_paging_domain_alloc()

2024-05-31 Thread Dmitry Baryshkov
On Fri, May 31, 2024 at 09:57:54AM +0800, Baolu Lu wrote: > On 5/30/24 3:58 PM, Dmitry Baryshkov wrote: > > On Thu, 30 May 2024 at 04:59, Baolu Lu wrote: > > > On 5/29/24 4:21 PM, Dmitry Baryshkov wrote: > > > > On Wed, May 29, 2024 at 01:32:36PM +0800, Lu Baolu wrote: > > > > > The domain allocat

Re: [PATCH 06/20] drm/msm: Use iommu_paging_domain_alloc()

2024-05-30 Thread Baolu Lu
On 5/30/24 3:58 PM, Dmitry Baryshkov wrote: On Thu, 30 May 2024 at 04:59, Baolu Lu wrote: On 5/29/24 4:21 PM, Dmitry Baryshkov wrote: On Wed, May 29, 2024 at 01:32:36PM +0800, Lu Baolu wrote: The domain allocated in msm_iommu_new() is for the @dev. Replace iommu_domain_alloc() with iommu_pagi

Re: [PATCH 06/20] drm/msm: Use iommu_paging_domain_alloc()

2024-05-30 Thread Dmitry Baryshkov
On Thu, 30 May 2024 at 04:59, Baolu Lu wrote: > > On 5/29/24 4:21 PM, Dmitry Baryshkov wrote: > > On Wed, May 29, 2024 at 01:32:36PM +0800, Lu Baolu wrote: > >> The domain allocated in msm_iommu_new() is for the @dev. Replace > >> iommu_domain_alloc() with iommu_paging_domain_alloc() to make it ex

Re: [PATCH 06/20] drm/msm: Use iommu_paging_domain_alloc()

2024-05-29 Thread Baolu Lu
On 5/29/24 4:21 PM, Dmitry Baryshkov wrote: On Wed, May 29, 2024 at 01:32:36PM +0800, Lu Baolu wrote: The domain allocated in msm_iommu_new() is for the @dev. Replace iommu_domain_alloc() with iommu_paging_domain_alloc() to make it explicit. Update msm_iommu_new() to always return ERR_PTR in fa

Re: [PATCH 06/20] drm/msm: Use iommu_paging_domain_alloc()

2024-05-29 Thread Dmitry Baryshkov
On Wed, May 29, 2024 at 01:32:36PM +0800, Lu Baolu wrote: > The domain allocated in msm_iommu_new() is for the @dev. Replace > iommu_domain_alloc() with iommu_paging_domain_alloc() to make it explicit. > > Update msm_iommu_new() to always return ERR_PTR in failure cases instead > of NULL. Please

[PATCH 06/20] drm/msm: Use iommu_paging_domain_alloc()

2024-05-28 Thread Lu Baolu
The domain allocated in msm_iommu_new() is for the @dev. Replace iommu_domain_alloc() with iommu_paging_domain_alloc() to make it explicit. Update msm_iommu_new() to always return ERR_PTR in failure cases instead of NULL. Signed-off-by: Lu Baolu --- drivers/gpu/drm/msm/msm_iommu.c | 8