Re: [PATCH 06/19] drm/vmwgfx: Drop the cursor locking hack

2017-03-29 Thread Thomas Hellstrom
On 03/29/2017 10:00 AM, Daniel Vetter wrote: > On Mon, Mar 27, 2017 at 10:31:51AM +0200, Thomas Hellstrom wrote: >> On 03/27/2017 08:28 AM, Daniel Vetter wrote: >>> We discussed this quickly on irc, transcribing. >>> >>> On Mon, Mar 27, 2017 at 5:01 AM, Michel Dänzer wrote: Strictly speaking,

Re: [PATCH 06/19] drm/vmwgfx: Drop the cursor locking hack

2017-03-29 Thread Daniel Vetter
On Mon, Mar 27, 2017 at 10:31:51AM +0200, Thomas Hellstrom wrote: > On 03/27/2017 08:28 AM, Daniel Vetter wrote: > > We discussed this quickly on irc, transcribing. > > > > On Mon, Mar 27, 2017 at 5:01 AM, Michel Dänzer wrote: > >> Strictly speaking, the (virtual) hardware is too limited to suppor

Re: [PATCH 06/19] drm/vmwgfx: Drop the cursor locking hack

2017-03-27 Thread Thomas Hellstrom
On 03/27/2017 08:28 AM, Daniel Vetter wrote: > We discussed this quickly on irc, transcribing. > > On Mon, Mar 27, 2017 at 5:01 AM, Michel Dänzer wrote: >> Strictly speaking, the (virtual) hardware is too limited to support the >> legacy KMS cursor API. AFAIR e.g. weston at least used to make use

Re: [PATCH 06/19] drm/vmwgfx: Drop the cursor locking hack

2017-03-26 Thread Daniel Vetter
We discussed this quickly on irc, transcribing. On Mon, Mar 27, 2017 at 5:01 AM, Michel Dänzer wrote: > Strictly speaking, the (virtual) hardware is too limited to support the > legacy KMS cursor API. AFAIR e.g. weston at least used to make use of HW > cursors for other surfaces, not sure that's

Re: [PATCH 06/19] drm/vmwgfx: Drop the cursor locking hack

2017-03-26 Thread Michel Dänzer
On 23/03/17 07:32 PM, Thomas Hellstrom wrote: > On 03/23/2017 11:10 AM, Daniel Vetter wrote: >> On Thu, Mar 23, 2017 at 09:35:25AM +0100, Thomas Hellstrom wrote: >>> On 03/23/2017 08:31 AM, Daniel Vetter wrote: On Thu, Mar 23, 2017 at 08:28:32AM +0100, Daniel Vetter wrote: > On Thu, Mar 23

Re: [PATCH 06/19] drm/vmwgfx: Drop the cursor locking hack

2017-03-23 Thread Daniel Vetter
On Thu, Mar 23, 2017 at 11:32:49AM +0100, Thomas Hellstrom wrote: > On 03/23/2017 11:10 AM, Daniel Vetter wrote: > > On Thu, Mar 23, 2017 at 09:35:25AM +0100, Thomas Hellstrom wrote: > >> Hi, Daniel, > >> > >> On 03/23/2017 08:31 AM, Daniel Vetter wrote: > >>> On Thu, Mar 23, 2017 at 08:28:32AM +01

Re: [PATCH 06/19] drm/vmwgfx: Drop the cursor locking hack

2017-03-23 Thread Thomas Hellstrom
On 03/23/2017 11:10 AM, Daniel Vetter wrote: > On Thu, Mar 23, 2017 at 09:35:25AM +0100, Thomas Hellstrom wrote: >> Hi, Daniel, >> >> On 03/23/2017 08:31 AM, Daniel Vetter wrote: >>> On Thu, Mar 23, 2017 at 08:28:32AM +0100, Daniel Vetter wrote: On Thu, Mar 23, 2017 at 07:22:31AM +0100, Thomas

Re: [PATCH 06/19] drm/vmwgfx: Drop the cursor locking hack

2017-03-23 Thread Daniel Vetter
On Thu, Mar 23, 2017 at 09:35:25AM +0100, Thomas Hellstrom wrote: > Hi, Daniel, > > On 03/23/2017 08:31 AM, Daniel Vetter wrote: > > On Thu, Mar 23, 2017 at 08:28:32AM +0100, Daniel Vetter wrote: > >> On Thu, Mar 23, 2017 at 07:22:31AM +0100, Thomas Hellstrom wrote: > >>> On 03/22/2017 10:50 PM, D

Re: [PATCH 06/19] drm/vmwgfx: Drop the cursor locking hack

2017-03-23 Thread Thomas Hellstrom
Hi, Daniel, On 03/23/2017 08:31 AM, Daniel Vetter wrote: > On Thu, Mar 23, 2017 at 08:28:32AM +0100, Daniel Vetter wrote: >> On Thu, Mar 23, 2017 at 07:22:31AM +0100, Thomas Hellstrom wrote: >>> On 03/22/2017 10:50 PM, Daniel Vetter wrote: It's been around forever, no one bothered to address

Re: [PATCH 06/19] drm/vmwgfx: Drop the cursor locking hack

2017-03-23 Thread Daniel Vetter
On Thu, Mar 23, 2017 at 08:28:32AM +0100, Daniel Vetter wrote: > On Thu, Mar 23, 2017 at 07:22:31AM +0100, Thomas Hellstrom wrote: > > On 03/22/2017 10:50 PM, Daniel Vetter wrote: > > > It's been around forever, no one bothered to address the FIXME, so I > > > presume it's all fine. > > > > > > Cc:

Re: [PATCH 06/19] drm/vmwgfx: Drop the cursor locking hack

2017-03-23 Thread Daniel Vetter
On Thu, Mar 23, 2017 at 07:22:31AM +0100, Thomas Hellstrom wrote: > On 03/22/2017 10:50 PM, Daniel Vetter wrote: > > It's been around forever, no one bothered to address the FIXME, so I > > presume it's all fine. > > > > Cc: Sinclair Yeh > > Cc: Thomas Hellstrom > > Signed-off-by: Daniel Vetter

Re: [PATCH 06/19] drm/vmwgfx: Drop the cursor locking hack

2017-03-22 Thread Thomas Hellstrom
On 03/22/2017 10:50 PM, Daniel Vetter wrote: > It's been around forever, no one bothered to address the FIXME, so I > presume it's all fine. > > Cc: Sinclair Yeh > Cc: Thomas Hellstrom > Signed-off-by: Daniel Vetter NAK. We need to properly address this. Probably as part of the atomic update. /

[PATCH 06/19] drm/vmwgfx: Drop the cursor locking hack

2017-03-22 Thread Daniel Vetter
It's been around forever, no one bothered to address the FIXME, so I presume it's all fine. Cc: Sinclair Yeh Cc: Thomas Hellstrom Signed-off-by: Daniel Vetter --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 25 - 1 file changed, 25 deletions(-) diff --git a/drivers/gpu/drm/v