Re: [PATCH 06/15] net: hbl_cn: debugfs support

2024-12-17 Thread Andrew Lunn
On Tue, Dec 17, 2024 at 12:00:39PM +0200, Avri Kehat wrote: > Revisiting the comments regarding our use of debugfs as an interface for > device configurations - > A big part of the non-statistics debugfs parameters are HW related debug-only > capabilities, and not configurations required by the u

Re: [PATCH 06/15] net: hbl_cn: debugfs support

2024-12-17 Thread Avri Kehat
Revisiting the comments regarding our use of debugfs as an interface for device configurations - A big part of the non-statistics debugfs parameters are HW related debug-only capabilities, and not configurations required by the user. Should these sort of parameters be part of devlink as well? Is

Re: [PATCH 06/15] net: hbl_cn: debugfs support

2024-06-24 Thread Leon Romanovsky
On Sun, Jun 23, 2024 at 05:02:44PM +0200, Andrew Lunn wrote: > > > If there is no netdev, what is the point of putting it into loopback? > > > How do you send packets which are to be looped back? How do you > > > receive them to see if they were actually looped back? > > > > > > Andrew > > > >

Re: [PATCH 06/15] net: hbl_cn: debugfs support

2024-06-24 Thread Omer Shpigelman
On 6/23/24 18:02, Andrew Lunn wrote: >>> If there is no netdev, what is the point of putting it into loopback? >>> How do you send packets which are to be looped back? How do you >>> receive them to see if they were actually looped back? >>> >>> Andrew >> >> To run RDMA test in loopback. > > W

Re: [PATCH 06/15] net: hbl_cn: debugfs support

2024-06-23 Thread Andrew Lunn
> > If there is no netdev, what is the point of putting it into loopback? > > How do you send packets which are to be looped back? How do you > > receive them to see if they were actually looped back? > > > > Andrew > > To run RDMA test in loopback. What is special about your RDMA? Why do yo

Re: [PATCH 06/15] net: hbl_cn: debugfs support

2024-06-23 Thread Omer Shpigelman
On 6/21/24 13:30, Sunil Kovvuri Goutham wrote: + +What: /sys/kernel/debug/habanalabs_cn/hbl_cn/nic_disable_decap +What: /sys/kernel/debug/habanalabs_cn/hbl_cn/nic_inject_rx_err +What: >> /sys/kernel/debug/habanalabs_cn/hbl_cn/nic_mac_lane_remap >>

Re: [PATCH 06/15] net: hbl_cn: debugfs support

2024-06-22 Thread Omer Shpigelman
On 6/21/24 18:33, Andrew Lunn wrote: >> I see other vendors have debugfs entries for debug configurations or >> settings, not just for dumping debug info. > > Did you see any added in the last few years? This is also something > DaveM pushed back on. We want uniform APIs so that all devices look >

Re: [PATCH 06/15] net: hbl_cn: debugfs support

2024-06-21 Thread Andrew Lunn
> I see other vendors have debugfs entries for debug configurations or > settings, not just for dumping debug info. Did you see any added in the last few years? This is also something DaveM pushed back on. We want uniform APIs so that all devices look alike. Please consider what you are exporting

RE: [PATCH 06/15] net: hbl_cn: debugfs support

2024-06-21 Thread Sunil Kovvuri Goutham
>>> + >>> +What: /sys/kernel/debug/habanalabs_cn/hbl_cn/nic_disable_decap >>> +What: /sys/kernel/debug/habanalabs_cn/hbl_cn/nic_inject_rx_err >>> +What: >/sys/kernel/debug/habanalabs_cn/hbl_cn/nic_mac_lane_remap >> >> Don't think debugfs is the correct interface for all this con

Re: [PATCH 06/15] net: hbl_cn: debugfs support

2024-06-21 Thread Omer Shpigelman
On 6/19/24 21:35, Sunil Kovvuri Goutham wrote: > [Some people who received this message don't often get email from > sgout...@marvell.com. Learn why this is important at > https://aka.ms/LearnAboutSenderIdentification ] > >> + >> +What: /sys/kernel/debug/habanalabs_cn/hbl_cn/nic_disabl

RE: [PATCH 06/15] net: hbl_cn: debugfs support

2024-06-19 Thread Sunil Kovvuri Goutham
>+ >+What: /sys/kernel/debug/habanalabs_cn/hbl_cn/nic_disable_decap >+What: /sys/kernel/debug/habanalabs_cn/hbl_cn/nic_inject_rx_err >+What: /sys/kernel/debug/habanalabs_cn/hbl_cn/nic_mac_lane_remap Don't think debugfs is the correct interface for all this configurat

[PATCH 06/15] net: hbl_cn: debugfs support

2024-06-14 Thread Omer Shpigelman
Add debugfs files for advanced settings, debug options and testing. Signed-off-by: Omer Shpigelman Co-developed-by: Abhilash K V Signed-off-by: Abhilash K V Co-developed-by: Andrey Agranovich Signed-off-by: Andrey Agranovich Co-developed-by: Bharat Jauhari Signed-off-by: Bharat Jauhari Co-d