Re: [PATCH 06/12] drm/legacy: move map_hash create/destroy into inlines

2019-04-23 Thread Sam Ravnborg
Hi Dave. Micro nit.. On Tue, Apr 23, 2019 at 12:00:35PM +1000, Dave Airlie wrote: > From: Dave Airlie > > This allows them to be removed later. > > Signed-off-by: Dave Airlie > --- > drivers/gpu/drm/drm_drv.c| 7 +++ > drivers/gpu/drm/drm_legacy.h | 10 ++ > 2 files changed,

Re: [PATCH 06/12] drm/legacy: move map_hash create/destroy into inlines

2019-04-23 Thread Daniel Vetter
On Tue, Apr 23, 2019 at 08:45:11PM +0200, Daniel Vetter wrote: > On Tue, Apr 23, 2019 at 12:00:35PM +1000, Dave Airlie wrote: > > From: Dave Airlie > > > > This allows them to be removed later. > > > > Signed-off-by: Dave Airlie > > vmwgfx still uses these? Is the plan to burn that down :-) >

Re: [PATCH 06/12] drm/legacy: move map_hash create/destroy into inlines

2019-04-23 Thread Daniel Vetter
On Tue, Apr 23, 2019 at 12:00:35PM +1000, Dave Airlie wrote: > From: Dave Airlie > > This allows them to be removed later. > > Signed-off-by: Dave Airlie vmwgfx still uses these? Is the plan to burn that down :-) Probably easier to add a todo.rst item to clean that up than do it yourself. -Da

[PATCH 06/12] drm/legacy: move map_hash create/destroy into inlines

2019-04-22 Thread Dave Airlie
From: Dave Airlie This allows them to be removed later. Signed-off-by: Dave Airlie --- drivers/gpu/drm/drm_drv.c| 7 +++ drivers/gpu/drm/drm_legacy.h | 10 ++ 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c