Re: [PATCH 06/10] drm/vkms: flush crc workers earlier in commit flow

2019-06-17 Thread Rodrigo Siqueira
On 06/13, Daniel Vetter wrote: > On Wed, Jun 12, 2019 at 10:42:42AM -0300, Rodrigo Siqueira wrote: > > On Thu, Jun 6, 2019 at 7:28 PM Daniel Vetter wrote: > > > > > > Currently we flush pending crc workers very late in the commit flow, > > > when we destry all the old crtc states. Unfortunately at

Re: [PATCH 06/10] drm/vkms: flush crc workers earlier in commit flow

2019-06-13 Thread Daniel Vetter
On Thu, Jun 13, 2019 at 09:53:55AM +0200, Daniel Vetter wrote: > On Wed, Jun 12, 2019 at 10:42:42AM -0300, Rodrigo Siqueira wrote: > > On Thu, Jun 6, 2019 at 7:28 PM Daniel Vetter wrote: > > > > > > Currently we flush pending crc workers very late in the commit flow, > > > when we destry all the o

Re: [PATCH 06/10] drm/vkms: flush crc workers earlier in commit flow

2019-06-13 Thread Daniel Vetter
On Wed, Jun 12, 2019 at 10:42:42AM -0300, Rodrigo Siqueira wrote: > On Thu, Jun 6, 2019 at 7:28 PM Daniel Vetter wrote: > > > > Currently we flush pending crc workers very late in the commit flow, > > when we destry all the old crtc states. Unfortunately at that point > > destry -> destroy > > >

Re: [PATCH 06/10] drm/vkms: flush crc workers earlier in commit flow

2019-06-12 Thread Rodrigo Siqueira
On Thu, Jun 6, 2019 at 7:28 PM Daniel Vetter wrote: > > Currently we flush pending crc workers very late in the commit flow, > when we destry all the old crtc states. Unfortunately at that point destry -> destroy > the framebuffers are already unpinned (and our vaddr possible gone), > so this is

[PATCH 06/10] drm/vkms: flush crc workers earlier in commit flow

2019-06-06 Thread Daniel Vetter
Currently we flush pending crc workers very late in the commit flow, when we destry all the old crtc states. Unfortunately at that point the framebuffers are already unpinned (and our vaddr possible gone), so this isn't good. Also, the plane_states we need might also already be cleaned up, since cl