[PATCH 05/18] drm/irq: remove cargo-culted locking from irq_install/unistall

2014-04-17 Thread Thierry Reding
On Thu, Apr 17, 2014 at 04:43:17PM +0200, Thierry Reding wrote: > On Fri, Apr 11, 2014 at 11:36:02PM +0200, Daniel Vetter wrote: > > The dev->struct_mutex locking in drm_irq.c only protects > > dev->irq_enabled. Which isn't really much at all and only prevents > > especially nasty ums userspace fro

[PATCH 05/18] drm/irq: remove cargo-culted locking from irq_install/unistall

2014-04-17 Thread Thierry Reding
On Fri, Apr 11, 2014 at 11:36:02PM +0200, Daniel Vetter wrote: > The dev->struct_mutex locking in drm_irq.c only protects > dev->irq_enabled. Which isn't really much at all and only prevents > especially nasty ums userspace from concurrently installing the > interrupt handling a few times. Or at le

[PATCH 05/18] drm/irq: remove cargo-culted locking from irq_install/unistall

2014-04-11 Thread Daniel Vetter
The dev->struct_mutex locking in drm_irq.c only protects dev->irq_enabled. Which isn't really much at all and only prevents especially nasty ums userspace from concurrently installing the interrupt handling a few times. Or at least trying. There are tons of unlocked readers of dev->irqs_enabled in