Re: [PATCH 05/12] drm/ast: Fix calculation of MCLK

2017-02-24 Thread Joel Stanley
On Fri, Feb 24, 2017 at 9:23 AM, Benjamin Herrenschmidt wrote: > Some braces were missing causing an incorrect calculation. > > Y.C. Chen from Aspeed provided me with the right formula > which I tested on AST2400 and 2500. Y. C. Chen, can you point out this calculation in the programming guide?

Re: [PATCH 05/12] drm/ast: Fix calculation of MCLK

2017-02-24 Thread Joel Stanley
On Fri, Feb 24, 2017 at 1:08 PM, Benjamin Herrenschmidt wrote: > On Fri, 2017-02-24 at 12:54 +1030, Joel Stanley wrote: >> On Fri, Feb 24, 2017 at 9:23 AM, Benjamin Herrenschmidt >> wrote: >> > Some braces were missing causing an incorrect calculation. >> > >> > Y.C. Chen from Aspeed provided me

RE: [PATCH 05/12] drm/ast: Fix calculation of MCLK

2017-02-23 Thread YC Chen
Tested-by: Y.C. Chen -Original Message- From: Benjamin Herrenschmidt [mailto:b...@kernel.crashing.org] Sent: Friday, February 24, 2017 6:54 AM To: dri-devel@lists.freedesktop.org Cc: YC Chen ; airl...@redhat.com; e...@suse.come; linuxppc-...@ozlabs.org Subject: [PATCH 05/12] drm/ast

Re: [PATCH 05/12] drm/ast: Fix calculation of MCLK

2017-02-23 Thread Benjamin Herrenschmidt
On Fri, 2017-02-24 at 12:54 +1030, Joel Stanley wrote: > On Fri, Feb 24, 2017 at 9:23 AM, Benjamin Herrenschmidt > wrote: > > Some braces were missing causing an incorrect calculation. > > > > Y.C. Chen from Aspeed provided me with the right formula > > which I tested on AST2400 and 2500. > > Y.

[PATCH 05/12] drm/ast: Fix calculation of MCLK

2017-02-23 Thread Benjamin Herrenschmidt
Some braces were missing causing an incorrect calculation. Y.C. Chen from Aspeed provided me with the right formula which I tested on AST2400 and 2500. The MCLK isn't currently used by the driver (it will eventually to filter modes) so the issue isn't catastrophic. Also make the printed value a