On Sat, 25 Jun 2022, Sam Ravnborg wrote:
> Hi Kevin,
>
> A few nitpicks in the following.
>
> Sam
>
> On Fri, Jun 24, 2022 at 03:26:09PM -0500, Kevin Brace wrote:
>> +typedef struct _via_lvds_info {
>> +u32 x;
>> +u32 y;
>> +} via_lvds_info;
> Make this look like:
> typedef struct vi
On Fri, 24 Jun 2022, Kevin Brace wrote:
> From: Kevin Brace
>
> Main header file for the module.
I sincerely suggest you reconsider this "main header file" approach.
It seems like a nice idea to only have to include one header in each
source file. Kind of feels cleaner in the C source. However,
Hi Kevin,
A few nitpicks in the following.
Sam
On Fri, Jun 24, 2022 at 03:26:09PM -0500, Kevin Brace wrote:
> From: Kevin Brace
>
> Main header file for the module.
>
> Signed-off-by: Kevin Brace
> ---
> drivers/gpu/drm/via/via_drv.h | 437 ++
> 1 fil
From: Kevin Brace
Main header file for the module.
Signed-off-by: Kevin Brace
---
drivers/gpu/drm/via/via_drv.h | 437 ++
1 file changed, 437 insertions(+)
create mode 100644 drivers/gpu/drm/via/via_drv.h
diff --git a/drivers/gpu/drm/via/via_drv.h b/drivers/gp
