Re: [Intel-gfx] [PATCH 04/21] drm/i915: Only use VBT panel mode on eDP if no EDID is found

2011-10-03 Thread Jesse Barnes
On Fri, 30 Sep 2011 10:58:26 -0700 Keith Packard wrote: > On Fri, 30 Sep 2011 18:32:35 +0200, Daniel Vetter wrote: > > > Ok, this is way over my head, just checked whether the patch does what it > > claims to - nice exercise in reading dp modeset code ;-) > > Yeah, it's purely heuristic -- the

[Intel-gfx] [PATCH 04/21] drm/i915: Only use VBT panel mode on eDP if no EDID is found

2011-10-03 Thread Jesse Barnes
On Fri, 30 Sep 2011 10:58:26 -0700 Keith Packard wrote: > On Fri, 30 Sep 2011 18:32:35 +0200, Daniel Vetter wrote: > > > Ok, this is way over my head, just checked whether the patch does what it > > claims to - nice exercise in reading dp modeset code ;-) > > Yeah, it's purely heuristic -- the

[PATCH 04/21] drm/i915: Only use VBT panel mode on eDP if no EDID is found

2011-09-30 Thread Daniel Vetter
On Thu, Sep 29, 2011 at 06:09:36PM -0700, Keith Packard wrote: > We're going to assume that EDID is more reliable than the VBT tables > for eDP panels, which is notably true on MacBook machines where the > VBT contains completely bogus data. > > Signed-off-by: Keith Packard Ok, this is way over m

Re: [PATCH 04/21] drm/i915: Only use VBT panel mode on eDP if no EDID is found

2011-09-30 Thread Keith Packard
On Fri, 30 Sep 2011 18:32:35 +0200, Daniel Vetter wrote: > Ok, this is way over my head, just checked whether the patch does what it > claims to - nice exercise in reading dp modeset code ;-) Yeah, it's purely heuristic -- the VBT contains a mode which was originally for the LVDS. It's unclear w

[PATCH 04/21] drm/i915: Only use VBT panel mode on eDP if no EDID is found

2011-09-30 Thread Keith Packard
On Fri, 30 Sep 2011 18:32:35 +0200, Daniel Vetter wrote: > Ok, this is way over my head, just checked whether the patch does what it > claims to - nice exercise in reading dp modeset code ;-) Yeah, it's purely heuristic -- the VBT contains a mode which was originally for the LVDS. It's unclear w

Re: [PATCH 04/21] drm/i915: Only use VBT panel mode on eDP if no EDID is found

2011-09-30 Thread Daniel Vetter
On Thu, Sep 29, 2011 at 06:09:36PM -0700, Keith Packard wrote: > We're going to assume that EDID is more reliable than the VBT tables > for eDP panels, which is notably true on MacBook machines where the > VBT contains completely bogus data. > > Signed-off-by: Keith Packard Ok, this is way over m

[PATCH 04/21] drm/i915: Only use VBT panel mode on eDP if no EDID is found

2011-09-29 Thread Keith Packard
We're going to assume that EDID is more reliable than the VBT tables for eDP panels, which is notably true on MacBook machines where the VBT contains completely bogus data. Signed-off-by: Keith Packard --- drivers/gpu/drm/i915/intel_dp.c | 20 ++-- 1 files changed, 10 insertion

[PATCH 04/21] drm/i915: Only use VBT panel mode on eDP if no EDID is found

2011-09-29 Thread Keith Packard
We're going to assume that EDID is more reliable than the VBT tables for eDP panels, which is notably true on MacBook machines where the VBT contains completely bogus data. Signed-off-by: Keith Packard --- drivers/gpu/drm/i915/intel_dp.c | 20 ++-- 1 files changed, 10 insertion