Re: [PATCH 04/15] dma-fence: Make ->wait callback optional

2018-07-02 Thread Christian König
Am 02.07.2018 um 10:23 schrieb Daniel Vetter: On Fri, May 04, 2018 at 03:47:59PM +0200, Daniel Vetter wrote: On Fri, May 04, 2018 at 03:17:08PM +0200, Christian König wrote: Am 04.05.2018 um 11:25 schrieb Daniel Vetter: On Fri, May 4, 2018 at 11:16 AM, Chris Wilson wrote: Quoting Daniel Vett

Re: [PATCH 04/15] dma-fence: Make ->wait callback optional

2018-07-02 Thread Daniel Vetter
On Fri, May 04, 2018 at 03:47:59PM +0200, Daniel Vetter wrote: > On Fri, May 04, 2018 at 03:17:08PM +0200, Christian König wrote: > > Am 04.05.2018 um 11:25 schrieb Daniel Vetter: > > > On Fri, May 4, 2018 at 11:16 AM, Chris Wilson > > > wrote: > > > > Quoting Daniel Vetter (2018-05-04 09:57:59)

Re: [PATCH 04/15] dma-fence: Make ->wait callback optional

2018-05-04 Thread Daniel Vetter
On Fri, May 04, 2018 at 03:17:08PM +0200, Christian König wrote: > Am 04.05.2018 um 11:25 schrieb Daniel Vetter: > > On Fri, May 4, 2018 at 11:16 AM, Chris Wilson > > wrote: > > > Quoting Daniel Vetter (2018-05-04 09:57:59) > > > > On Fri, May 04, 2018 at 09:31:33AM +0100, Chris Wilson wrote: > >

Re: [PATCH 04/15] dma-fence: Make ->wait callback optional

2018-05-04 Thread Christian König
Am 04.05.2018 um 11:25 schrieb Daniel Vetter: On Fri, May 4, 2018 at 11:16 AM, Chris Wilson wrote: Quoting Daniel Vetter (2018-05-04 09:57:59) On Fri, May 04, 2018 at 09:31:33AM +0100, Chris Wilson wrote: Quoting Daniel Vetter (2018-05-04 09:23:01) On Fri, May 04, 2018 at 10:17:22AM +0200, D

Re: [PATCH 04/15] dma-fence: Make ->wait callback optional

2018-05-04 Thread Daniel Vetter
On Fri, May 4, 2018 at 11:16 AM, Chris Wilson wrote: > Quoting Daniel Vetter (2018-05-04 09:57:59) >> On Fri, May 04, 2018 at 09:31:33AM +0100, Chris Wilson wrote: >> > Quoting Daniel Vetter (2018-05-04 09:23:01) >> > > On Fri, May 04, 2018 at 10:17:22AM +0200, Daniel Vetter wrote: >> > > > On Fri

Re: [PATCH 04/15] dma-fence: Make ->wait callback optional

2018-05-04 Thread Chris Wilson
Quoting Daniel Vetter (2018-05-04 09:57:59) > On Fri, May 04, 2018 at 09:31:33AM +0100, Chris Wilson wrote: > > Quoting Daniel Vetter (2018-05-04 09:23:01) > > > On Fri, May 04, 2018 at 10:17:22AM +0200, Daniel Vetter wrote: > > > > On Fri, May 04, 2018 at 09:09:10AM +0100, Chris Wilson wrote: > >

Re: [PATCH 04/15] dma-fence: Make ->wait callback optional

2018-05-04 Thread Daniel Vetter
On Fri, May 04, 2018 at 09:31:33AM +0100, Chris Wilson wrote: > Quoting Daniel Vetter (2018-05-04 09:23:01) > > On Fri, May 04, 2018 at 10:17:22AM +0200, Daniel Vetter wrote: > > > On Fri, May 04, 2018 at 09:09:10AM +0100, Chris Wilson wrote: > > > > Quoting Daniel Vetter (2018-05-03 15:25:52) > >

Re: [PATCH 04/15] dma-fence: Make ->wait callback optional

2018-05-04 Thread Chris Wilson
Quoting Daniel Vetter (2018-05-04 09:23:01) > On Fri, May 04, 2018 at 10:17:22AM +0200, Daniel Vetter wrote: > > On Fri, May 04, 2018 at 09:09:10AM +0100, Chris Wilson wrote: > > > Quoting Daniel Vetter (2018-05-03 15:25:52) > > > > Almost everyone uses dma_fence_default_wait. > > > > > > > > v2:

Re: [PATCH 04/15] dma-fence: Make ->wait callback optional

2018-05-04 Thread Daniel Vetter
On Fri, May 04, 2018 at 10:17:22AM +0200, Daniel Vetter wrote: > On Fri, May 04, 2018 at 09:09:10AM +0100, Chris Wilson wrote: > > Quoting Daniel Vetter (2018-05-03 15:25:52) > > > Almost everyone uses dma_fence_default_wait. > > > > > > v2: Also remove the BUG_ON(!ops->wait) (Chris). > > > > I j

Re: [PATCH 04/15] dma-fence: Make ->wait callback optional

2018-05-04 Thread Daniel Vetter
On Fri, May 04, 2018 at 09:09:10AM +0100, Chris Wilson wrote: > Quoting Daniel Vetter (2018-05-03 15:25:52) > > Almost everyone uses dma_fence_default_wait. > > > > v2: Also remove the BUG_ON(!ops->wait) (Chris). > > I just don't get the rationale for implicit over explicit. Closer approximation

Re: [PATCH 04/15] dma-fence: Make ->wait callback optional

2018-05-04 Thread Chris Wilson
Quoting Daniel Vetter (2018-05-03 15:25:52) > Almost everyone uses dma_fence_default_wait. > > v2: Also remove the BUG_ON(!ops->wait) (Chris). I just don't get the rationale for implicit over explicit. -Chris ___ dri-devel mailing list dri-devel@lists.f

[PATCH 04/15] dma-fence: Make ->wait callback optional

2018-05-03 Thread Daniel Vetter
Almost everyone uses dma_fence_default_wait. v2: Also remove the BUG_ON(!ops->wait) (Chris). Reviewed-by: Christian König (v1) Signed-off-by: Daniel Vetter Cc: Chris Wilson Cc: Sumit Semwal Cc: Gustavo Padovan Cc: linux-me...@vger.kernel.org Cc: linaro-mm-...@lists.linaro.org --- drivers/dm