Re: [PATCH 04/10] phy: dphy: Add configuration helpers

2018-09-10 Thread Laurent Pinchart
Hi Maxime, On Monday, 10 September 2018 17:16:03 EEST Maxime Ripard wrote: > On Fri, Sep 07, 2018 at 05:26:29PM +0300, Laurent Pinchart wrote: > + */ > +int phy_mipi_dphy_get_default_config(unsigned long pixel_clock, > + unsigned int bpp, > +

Re: [PATCH 04/10] phy: dphy: Add configuration helpers

2018-09-10 Thread Maxime Ripard
Hi, On Fri, Sep 07, 2018 at 05:26:29PM +0300, Laurent Pinchart wrote: > > >> + */ > > >> +int phy_mipi_dphy_get_default_config(unsigned long pixel_clock, > > >> + unsigned int bpp, > > >> + unsigned int lanes, > > >> +

Re: [PATCH 04/10] phy: dphy: Add configuration helpers

2018-09-07 Thread Laurent Pinchart
Hi Maxime, On Friday, 7 September 2018 16:37:39 EEST Maxime Ripard wrote: > On Wed, Sep 05, 2018 at 04:46:05PM +0300, Laurent Pinchart wrote: > > On Wednesday, 5 September 2018 12:16:35 EEST Maxime Ripard wrote: > >> The MIPI D-PHY spec defines default values and boundaries for most of > >> the pa

Re: [PATCH 04/10] phy: dphy: Add configuration helpers

2018-09-07 Thread Maxime Ripard
On Wed, Sep 05, 2018 at 04:46:05PM +0300, Laurent Pinchart wrote: > Hi Maxime, > > Thank you for the patch. > > On Wednesday, 5 September 2018 12:16:35 EEST Maxime Ripard wrote: > > The MIPI D-PHY spec defines default values and boundaries for most of the > > parameters it defines. Introduce help

Re: [PATCH 04/10] phy: dphy: Add configuration helpers

2018-09-05 Thread Laurent Pinchart
Hi Maxime, Thank you for the patch. On Wednesday, 5 September 2018 12:16:35 EEST Maxime Ripard wrote: > The MIPI D-PHY spec defines default values and boundaries for most of the > parameters it defines. Introduce helpers to help drivers get meaningful > values based on their current parameters, a

[PATCH 04/10] phy: dphy: Add configuration helpers

2018-09-05 Thread Maxime Ripard
The MIPI D-PHY spec defines default values and boundaries for most of the parameters it defines. Introduce helpers to help drivers get meaningful values based on their current parameters, and validate the boundaries of these parameters if needed. Signed-off-by: Maxime Ripard --- drivers/phy/Kcon