[PATCH 04/10] drm/ttm: change fence_lock to inner lock, v3

2012-11-27 Thread Maarten Lankhorst
Op 22-11-12 21:29, Thomas Hellstrom schreef: > On 11/22/2012 04:51 PM, Maarten Lankhorst wrote: >> Op 21-11-12 14:27, Thomas Hellstrom schreef: >>> On 11/21/2012 02:12 PM, Maarten Lankhorst wrote: Op 21-11-12 13:42, Thomas Hellstrom schreef: > On 11/21/2012 12:38 PM, Maarten Lankhorst wrot

Re: [PATCH 04/10] drm/ttm: change fence_lock to inner lock, v3

2012-11-27 Thread Maarten Lankhorst
Op 22-11-12 21:29, Thomas Hellstrom schreef: > On 11/22/2012 04:51 PM, Maarten Lankhorst wrote: >> Op 21-11-12 14:27, Thomas Hellstrom schreef: >>> On 11/21/2012 02:12 PM, Maarten Lankhorst wrote: Op 21-11-12 13:42, Thomas Hellstrom schreef: > On 11/21/2012 12:38 PM, Maarten Lankhorst wrot

[PATCH 04/10] drm/ttm: change fence_lock to inner lock, v3

2012-11-22 Thread Thomas Hellstrom
On 11/22/2012 04:51 PM, Maarten Lankhorst wrote: > Op 21-11-12 14:27, Thomas Hellstrom schreef: >> On 11/21/2012 02:12 PM, Maarten Lankhorst wrote: >>> Op 21-11-12 13:42, Thomas Hellstrom schreef: On 11/21/2012 12:38 PM, Maarten Lankhorst wrote: > Hey, > > Op 20-11-12 16:08, Thomas

[PATCH 04/10] drm/ttm: change fence_lock to inner lock, v3

2012-11-22 Thread Maarten Lankhorst
Op 21-11-12 14:27, Thomas Hellstrom schreef: > On 11/21/2012 02:12 PM, Maarten Lankhorst wrote: >> Op 21-11-12 13:42, Thomas Hellstrom schreef: >>> On 11/21/2012 12:38 PM, Maarten Lankhorst wrote: Hey, Op 20-11-12 16:08, Thomas Hellstrom schreef: > On 11/20/2012 02:13 PM, Maarten

Re: [PATCH 04/10] drm/ttm: change fence_lock to inner lock, v3

2012-11-22 Thread Thomas Hellstrom
On 11/22/2012 04:51 PM, Maarten Lankhorst wrote: Op 21-11-12 14:27, Thomas Hellstrom schreef: On 11/21/2012 02:12 PM, Maarten Lankhorst wrote: Op 21-11-12 13:42, Thomas Hellstrom schreef: On 11/21/2012 12:38 PM, Maarten Lankhorst wrote: Hey, Op 20-11-12 16:08, Thomas Hellstrom schreef: On 1

Re: [PATCH 04/10] drm/ttm: change fence_lock to inner lock, v3

2012-11-22 Thread Maarten Lankhorst
Op 21-11-12 14:27, Thomas Hellstrom schreef: > On 11/21/2012 02:12 PM, Maarten Lankhorst wrote: >> Op 21-11-12 13:42, Thomas Hellstrom schreef: >>> On 11/21/2012 12:38 PM, Maarten Lankhorst wrote: Hey, Op 20-11-12 16:08, Thomas Hellstrom schreef: > On 11/20/2012 02:13 PM, Maarten

[PATCH 04/10] drm/ttm: change fence_lock to inner lock, v3

2012-11-21 Thread Thomas Hellstrom
On 11/21/2012 02:12 PM, Maarten Lankhorst wrote: > Op 21-11-12 13:42, Thomas Hellstrom schreef: >> On 11/21/2012 12:38 PM, Maarten Lankhorst wrote: >>> Hey, >>> >>> Op 20-11-12 16:08, Thomas Hellstrom schreef: On 11/20/2012 02:13 PM, Maarten Lankhorst wrote: > Op 20-11-12 13:03, Thomas Hel

[PATCH 04/10] drm/ttm: change fence_lock to inner lock, v3

2012-11-21 Thread Maarten Lankhorst
Op 21-11-12 13:42, Thomas Hellstrom schreef: > On 11/21/2012 12:38 PM, Maarten Lankhorst wrote: >> Hey, >> >> Op 20-11-12 16:08, Thomas Hellstrom schreef: >>> On 11/20/2012 02:13 PM, Maarten Lankhorst wrote: Op 20-11-12 13:03, Thomas Hellstrom schreef: > On 11/20/2012 12:33 PM, Maarten Lan

[PATCH 04/10] drm/ttm: change fence_lock to inner lock, v3

2012-11-21 Thread Thomas Hellstrom
On 11/21/2012 12:38 PM, Maarten Lankhorst wrote: > Hey, > > Op 20-11-12 16:08, Thomas Hellstrom schreef: >> On 11/20/2012 02:13 PM, Maarten Lankhorst wrote: >>> Op 20-11-12 13:03, Thomas Hellstrom schreef: On 11/20/2012 12:33 PM, Maarten Lankhorst wrote: > Op 20-11-12 08:48, Thomas Hellstr

[PATCH 04/10] drm/ttm: change fence_lock to inner lock, v3

2012-11-21 Thread Maarten Lankhorst
Hey, Op 20-11-12 16:08, Thomas Hellstrom schreef: > On 11/20/2012 02:13 PM, Maarten Lankhorst wrote: >> Op 20-11-12 13:03, Thomas Hellstrom schreef: >>> On 11/20/2012 12:33 PM, Maarten Lankhorst wrote: Op 20-11-12 08:48, Thomas Hellstrom schreef: > On 11/19/2012 04:33 PM, Maarten Lankhors

Re: [PATCH 04/10] drm/ttm: change fence_lock to inner lock, v3

2012-11-21 Thread Thomas Hellstrom
On 11/21/2012 02:12 PM, Maarten Lankhorst wrote: Op 21-11-12 13:42, Thomas Hellstrom schreef: On 11/21/2012 12:38 PM, Maarten Lankhorst wrote: Hey, Op 20-11-12 16:08, Thomas Hellstrom schreef: On 11/20/2012 02:13 PM, Maarten Lankhorst wrote: Op 20-11-12 13:03, Thomas Hellstrom schreef: On 1

Re: [PATCH 04/10] drm/ttm: change fence_lock to inner lock, v3

2012-11-21 Thread Maarten Lankhorst
Op 21-11-12 13:42, Thomas Hellstrom schreef: > On 11/21/2012 12:38 PM, Maarten Lankhorst wrote: >> Hey, >> >> Op 20-11-12 16:08, Thomas Hellstrom schreef: >>> On 11/20/2012 02:13 PM, Maarten Lankhorst wrote: Op 20-11-12 13:03, Thomas Hellstrom schreef: > On 11/20/2012 12:33 PM, Maarten Lan

Re: [PATCH 04/10] drm/ttm: change fence_lock to inner lock, v3

2012-11-21 Thread Thomas Hellstrom
On 11/21/2012 12:38 PM, Maarten Lankhorst wrote: Hey, Op 20-11-12 16:08, Thomas Hellstrom schreef: On 11/20/2012 02:13 PM, Maarten Lankhorst wrote: Op 20-11-12 13:03, Thomas Hellstrom schreef: On 11/20/2012 12:33 PM, Maarten Lankhorst wrote: Op 20-11-12 08:48, Thomas Hellstrom schreef: On 1

Re: [PATCH 04/10] drm/ttm: change fence_lock to inner lock, v3

2012-11-21 Thread Maarten Lankhorst
Hey, Op 20-11-12 16:08, Thomas Hellstrom schreef: > On 11/20/2012 02:13 PM, Maarten Lankhorst wrote: >> Op 20-11-12 13:03, Thomas Hellstrom schreef: >>> On 11/20/2012 12:33 PM, Maarten Lankhorst wrote: Op 20-11-12 08:48, Thomas Hellstrom schreef: > On 11/19/2012 04:33 PM, Maarten Lankhors

[PATCH 04/10] drm/ttm: change fence_lock to inner lock, v3

2012-11-20 Thread Thomas Hellstrom
On 11/20/2012 02:13 PM, Maarten Lankhorst wrote: > Op 20-11-12 13:03, Thomas Hellstrom schreef: >> On 11/20/2012 12:33 PM, Maarten Lankhorst wrote: >>> Op 20-11-12 08:48, Thomas Hellstrom schreef: On 11/19/2012 04:33 PM, Maarten Lankhorst wrote: > Op 19-11-12 16:04, Thomas Hellstrom schree

[PATCH 04/10] drm/ttm: change fence_lock to inner lock, v3

2012-11-20 Thread Maarten Lankhorst
Op 20-11-12 13:03, Thomas Hellstrom schreef: > On 11/20/2012 12:33 PM, Maarten Lankhorst wrote: >> Op 20-11-12 08:48, Thomas Hellstrom schreef: >>> On 11/19/2012 04:33 PM, Maarten Lankhorst wrote: Op 19-11-12 16:04, Thomas Hellstrom schreef: > On 11/19/2012 03:17 PM, Thomas Hellstrom wrote

[PATCH 04/10] drm/ttm: change fence_lock to inner lock, v3

2012-11-20 Thread Thomas Hellstrom
On 11/20/2012 12:33 PM, Maarten Lankhorst wrote: > Op 20-11-12 08:48, Thomas Hellstrom schreef: >> On 11/19/2012 04:33 PM, Maarten Lankhorst wrote: >>> Op 19-11-12 16:04, Thomas Hellstrom schreef: On 11/19/2012 03:17 PM, Thomas Hellstrom wrote: > Hi, > > This patch looks mostly goo

[PATCH 04/10] drm/ttm: change fence_lock to inner lock, v3

2012-11-20 Thread Maarten Lankhorst
Op 20-11-12 12:33, Maarten Lankhorst schreef: > Op 20-11-12 08:48, Thomas Hellstrom schreef: >> On 11/19/2012 04:33 PM, Maarten Lankhorst wrote: >>> Op 19-11-12 16:04, Thomas Hellstrom schreef: On 11/19/2012 03:17 PM, Thomas Hellstrom wrote: > Hi, > > This patch looks mostly good,

[PATCH 04/10] drm/ttm: change fence_lock to inner lock, v3

2012-11-20 Thread Maarten Lankhorst
Op 20-11-12 08:48, Thomas Hellstrom schreef: > On 11/19/2012 04:33 PM, Maarten Lankhorst wrote: >> Op 19-11-12 16:04, Thomas Hellstrom schreef: >>> On 11/19/2012 03:17 PM, Thomas Hellstrom wrote: Hi, This patch looks mostly good, although I think ttm_bo_cleanup_refs becomes ove

[PATCH 04/10] drm/ttm: change fence_lock to inner lock, v3

2012-11-20 Thread Thomas Hellstrom
On 11/19/2012 04:33 PM, Maarten Lankhorst wrote: > Op 19-11-12 16:04, Thomas Hellstrom schreef: >> On 11/19/2012 03:17 PM, Thomas Hellstrom wrote: >>> Hi, >>> >>> This patch looks mostly good, although I think ttm_bo_cleanup_refs becomes >>> overly complicated: >>> Could this do, or am I missing s

Re: [PATCH 04/10] drm/ttm: change fence_lock to inner lock, v3

2012-11-20 Thread Thomas Hellstrom
On 11/20/2012 02:13 PM, Maarten Lankhorst wrote: Op 20-11-12 13:03, Thomas Hellstrom schreef: On 11/20/2012 12:33 PM, Maarten Lankhorst wrote: Op 20-11-12 08:48, Thomas Hellstrom schreef: On 11/19/2012 04:33 PM, Maarten Lankhorst wrote: Op 19-11-12 16:04, Thomas Hellstrom schreef: On 11/19/2

Re: [PATCH 04/10] drm/ttm: change fence_lock to inner lock, v3

2012-11-20 Thread Maarten Lankhorst
Op 20-11-12 13:03, Thomas Hellstrom schreef: > On 11/20/2012 12:33 PM, Maarten Lankhorst wrote: >> Op 20-11-12 08:48, Thomas Hellstrom schreef: >>> On 11/19/2012 04:33 PM, Maarten Lankhorst wrote: Op 19-11-12 16:04, Thomas Hellstrom schreef: > On 11/19/2012 03:17 PM, Thomas Hellstrom wrote

Re: [PATCH 04/10] drm/ttm: change fence_lock to inner lock, v3

2012-11-20 Thread Thomas Hellstrom
On 11/20/2012 12:33 PM, Maarten Lankhorst wrote: Op 20-11-12 08:48, Thomas Hellstrom schreef: On 11/19/2012 04:33 PM, Maarten Lankhorst wrote: Op 19-11-12 16:04, Thomas Hellstrom schreef: On 11/19/2012 03:17 PM, Thomas Hellstrom wrote: Hi, This patch looks mostly good, although I think ttm_b

Re: [PATCH 04/10] drm/ttm: change fence_lock to inner lock, v3

2012-11-20 Thread Maarten Lankhorst
Op 20-11-12 12:33, Maarten Lankhorst schreef: > Op 20-11-12 08:48, Thomas Hellstrom schreef: >> On 11/19/2012 04:33 PM, Maarten Lankhorst wrote: >>> Op 19-11-12 16:04, Thomas Hellstrom schreef: On 11/19/2012 03:17 PM, Thomas Hellstrom wrote: > Hi, > > This patch looks mostly good,

Re: [PATCH 04/10] drm/ttm: change fence_lock to inner lock, v3

2012-11-20 Thread Maarten Lankhorst
Op 20-11-12 08:48, Thomas Hellstrom schreef: > On 11/19/2012 04:33 PM, Maarten Lankhorst wrote: >> Op 19-11-12 16:04, Thomas Hellstrom schreef: >>> On 11/19/2012 03:17 PM, Thomas Hellstrom wrote: Hi, This patch looks mostly good, although I think ttm_bo_cleanup_refs becomes ove

Re: [PATCH 04/10] drm/ttm: change fence_lock to inner lock, v3

2012-11-19 Thread Thomas Hellstrom
On 11/19/2012 04:33 PM, Maarten Lankhorst wrote: Op 19-11-12 16:04, Thomas Hellstrom schreef: On 11/19/2012 03:17 PM, Thomas Hellstrom wrote: Hi, This patch looks mostly good, although I think ttm_bo_cleanup_refs becomes overly complicated: Could this do, or am I missing something? Actually

[PATCH 04/10] drm/ttm: change fence_lock to inner lock, v3

2012-11-19 Thread Maarten Lankhorst
Op 19-11-12 16:04, Thomas Hellstrom schreef: > On 11/19/2012 03:17 PM, Thomas Hellstrom wrote: >> Hi, >> >> This patch looks mostly good, although I think ttm_bo_cleanup_refs becomes >> overly complicated: >> Could this do, or am I missing something? >> > > Actually, my version is bad, because ttm

[PATCH 04/10] drm/ttm: change fence_lock to inner lock, v3

2012-11-19 Thread Thomas Hellstrom
On 11/19/2012 03:17 PM, Thomas Hellstrom wrote: > Hi, > > This patch looks mostly good, although I think ttm_bo_cleanup_refs > becomes overly complicated: > Could this do, or am I missing something? > Actually, my version is bad, because ttm_bo_wait() is called with the lru lock held. /Thomas

[PATCH 04/10] drm/ttm: change fence_lock to inner lock, v3

2012-11-19 Thread Thomas Hellstrom
Hi, This patch looks mostly good, although I think ttm_bo_cleanup_refs becomes overly complicated: Could this do, or am I missing something? static int ttm_bo_cleanup_refs(struct ttm_buffer_object *bo, bool interruptible, bool no_wait_reserve,

Re: [PATCH 04/10] drm/ttm: change fence_lock to inner lock, v3

2012-11-19 Thread Maarten Lankhorst
Op 19-11-12 16:04, Thomas Hellstrom schreef: > On 11/19/2012 03:17 PM, Thomas Hellstrom wrote: >> Hi, >> >> This patch looks mostly good, although I think ttm_bo_cleanup_refs becomes >> overly complicated: >> Could this do, or am I missing something? >> > > Actually, my version is bad, because ttm

Re: [PATCH 04/10] drm/ttm: change fence_lock to inner lock, v3

2012-11-19 Thread Thomas Hellstrom
On 11/19/2012 03:17 PM, Thomas Hellstrom wrote: Hi, This patch looks mostly good, although I think ttm_bo_cleanup_refs becomes overly complicated: Could this do, or am I missing something? Actually, my version is bad, because ttm_bo_wait() is called with the lru lock held. /Thomas st

Re: [PATCH 04/10] drm/ttm: change fence_lock to inner lock, v3

2012-11-19 Thread Thomas Hellstrom
Hi, This patch looks mostly good, although I think ttm_bo_cleanup_refs becomes overly complicated: Could this do, or am I missing something? static int ttm_bo_cleanup_refs(struct ttm_buffer_object *bo, bool interruptible, bool no_wait_reserve,

[PATCH 04/10] drm/ttm: change fence_lock to inner lock, v3

2012-11-12 Thread Maarten Lankhorst
I changed the hierarchy to make fence_lock the most inner lock, instead of outer lock. This will simplify things slightly, and hopefully makes it easier to make fence_lock global at one point should it be needed. To make things clearer, I change the order around in ttm_bo_cleanup_refs and ttm_bo_c

[PATCH 04/10] drm/ttm: change fence_lock to inner lock, v3

2012-11-12 Thread Maarten Lankhorst
I changed the hierarchy to make fence_lock the most inner lock, instead of outer lock. This will simplify things slightly, and hopefully makes it easier to make fence_lock global at one point should it be needed. To make things clearer, I change the order around in ttm_bo_cleanup_refs and ttm_bo_c