Re: [Intel-gfx] [PATCH 03/26] drm/irq: Ditch DRIVER_IRQ_SHARED

2019-01-28 Thread Emil Velikov
On 2019/01/25, Daniel Vetter wrote: > On Fri, Jan 25, 2019 at 02:46:55PM +, Emil Velikov wrote: > > On Thu, 24 Jan 2019 at 16:58, Daniel Vetter wrote: > > > > > > This is only used by drm_irq_install(), which is an optional helper. > > > And the right choice is to set it for all pci devices, a

Re: [Intel-gfx] [PATCH 03/26] drm/irq: Ditch DRIVER_IRQ_SHARED

2019-01-25 Thread Daniel Vetter
On Fri, Jan 25, 2019 at 02:46:55PM +, Emil Velikov wrote: > On Thu, 24 Jan 2019 at 16:58, Daniel Vetter wrote: > > > > This is only used by drm_irq_install(), which is an optional helper. > > And the right choice is to set it for all pci devices, and not for > > everything else. > > > Can you

Re: [Intel-gfx] [PATCH 03/26] drm/irq: Ditch DRIVER_IRQ_SHARED

2019-01-25 Thread Emil Velikov
On Thu, 24 Jan 2019 at 16:58, Daniel Vetter wrote: > > This is only used by drm_irq_install(), which is an optional helper. > And the right choice is to set it for all pci devices, and not for > everything else. > Can you please add some information (or reference) why it's the right choice? Thank

[PATCH 03/26] drm/irq: Ditch DRIVER_IRQ_SHARED

2019-01-24 Thread Daniel Vetter
This is only used by drm_irq_install(), which is an optional helper. And the right choice is to set it for all pci devices, and not for everything else. Any driver with special needs should just use request_irq() directly, and there's plenty of drivers doing that already. Signed-off-by: Daniel Ve