Re: Re: [PATCH 03/14] drm/atmel-hlcdc: Convert to Linux IRQ interfaces

2021-07-30 Thread Dan.Sneddon
On 7/30/21 1:31 AM, Thomas Zimmermann wrote: > Hi Dan and Sam > > Am 29.07.21 um 21:55 schrieb dan.sned...@microchip.com: >> Hi Thomas and Sam, >> On 7/29/21 12:48 PM, Sam Ravnborg wrote: >>> EXTERNAL EMAIL: Do not click links or open attachments unless you >>> know the content is safe >>> >>> Hi

Re: [PATCH 03/14] drm/atmel-hlcdc: Convert to Linux IRQ interfaces

2021-07-30 Thread Thomas Zimmermann
Hi Dan and Sam Am 29.07.21 um 21:55 schrieb dan.sned...@microchip.com: Hi Thomas and Sam, On 7/29/21 12:48 PM, Sam Ravnborg wrote: EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe Hi Thomas, Are you sure, you're testing with the latest drm-misc-nex

Re: [PATCH 03/14] drm/atmel-hlcdc: Convert to Linux IRQ interfaces

2021-07-29 Thread Dan.Sneddon
Hi Thomas and Sam, On 7/29/21 12:48 PM, Sam Ravnborg wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Hi Thomas, > >> >> Are you sure, you're testing with the latest drm-misc-next or drm-tip? >> Because using irq_enabled is deprecated and

Re: Re: [PATCH 03/14] drm/atmel-hlcdc: Convert to Linux IRQ interfaces

2021-07-29 Thread Dan.Sneddon
Hi Thomas, On 7/29/21 12:18 PM, Thomas Zimmermann wrote: > Hi > > Am 28.07.21 um 22:11 schrieb Sam Ravnborg: >> Hi Dan, >> I think I got it - we need to set irq_enabled to true. The documentation says so: "    * @irq_enabled:    *    * In

Re: [PATCH 03/14] drm/atmel-hlcdc: Convert to Linux IRQ interfaces

2021-07-29 Thread Sam Ravnborg
Hi Thomas, > > Are you sure, you're testing with the latest drm-misc-next or drm-tip? > Because using irq_enabled is deprecated and the flag was recently replaced > by commit 1e4cd78ed493 ("drm: Don't test for IRQ support in VBLANK ioctls"). I was looking at drm-misc-fixes which did not have thi

Re: [PATCH 03/14] drm/atmel-hlcdc: Convert to Linux IRQ interfaces

2021-07-29 Thread Thomas Zimmermann
Hi Am 29.07.21 um 21:24 schrieb dan.sned...@microchip.com: Hi Thomas, On 7/29/21 12:18 PM, Thomas Zimmermann wrote: Hi Am 28.07.21 um 22:11 schrieb Sam Ravnborg: Hi Dan, I think I got it - we need to set irq_enabled to true. The documentation says so: "    * @irq_enabled:   

Re: [PATCH 03/14] drm/atmel-hlcdc: Convert to Linux IRQ interfaces

2021-07-29 Thread Thomas Zimmermann
Hi Am 29.07.21 um 21:18 schrieb Thomas Zimmermann: Hi Am 28.07.21 um 22:11 schrieb Sam Ravnborg: Hi Dan, I think I got it - we need to set irq_enabled to true. The documentation says so: "    * @irq_enabled:    *    * Indicates that interrupt handling is enabled, sp

Re: [PATCH 03/14] drm/atmel-hlcdc: Convert to Linux IRQ interfaces

2021-07-29 Thread Thomas Zimmermann
Hi Am 28.07.21 um 22:11 schrieb Sam Ravnborg: Hi Dan, I think I got it - we need to set irq_enabled to true. The documentation says so: " * @irq_enabled: * * Indicates that interrupt handling is enabled, specifically vblank * handling. Drivers which

Re: [PATCH 03/14] drm/atmel-hlcdc: Convert to Linux IRQ interfaces

2021-07-28 Thread Dan.Sneddon
Hi Sam, On 7/28/21 12:08 PM, Sam Ravnborg wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Hi Dan, > Just to be sure... Can you confirm that vbltest is working OK *before* this patch? >>> >>> Yes, can you please verify that

Re: Re: [PATCH 03/14] drm/atmel-hlcdc: Convert to Linux IRQ interfaces

2021-07-28 Thread Dan.Sneddon
Hi Thomas, On 7/28/21 11:17 AM, Thomas Zimmermann wrote: > Hi > > Am 28.07.21 um 20:11 schrieb Sam Ravnborg: >> Hi Dan, >> >> thanks for the quick feedback! >> >> On Wed, Jul 28, 2021 at 05:50:34PM +, dan.sned...@microchip.com >> wrote: >>> On 7/28/21 8:44 AM, Sam Ravnborg wrote: EXTERN

Re: [PATCH 03/14] drm/atmel-hlcdc: Convert to Linux IRQ interfaces

2021-07-28 Thread Dan.Sneddon
On 7/28/21 11:11 AM, Sam Ravnborg wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Hi Dan, > > thanks for the quick feedback! > > On Wed, Jul 28, 2021 at 05:50:34PM +, dan.sned...@microchip.com wrote: >> On 7/28/21 8:44 AM, Sam Ravnbo

Re: [PATCH 03/14] drm/atmel-hlcdc: Convert to Linux IRQ interfaces

2021-07-28 Thread Dan.Sneddon
On 7/28/21 8:44 AM, Sam Ravnborg wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Hi Dan, > > On Wed, Jul 28, 2021 at 03:11:08PM +, dan.sned...@microchip.com wrote: >> On 7/28/21 7:00 AM, Sam Ravnborg wrote: >>> [You don't often get em

Re: [PATCH 03/14] drm/atmel-hlcdc: Convert to Linux IRQ interfaces

2021-07-28 Thread Sam Ravnborg
Hi Dan, > > > > I think I got it - we need to set irq_enabled to true. > > The documentation says so: > > " > > * @irq_enabled: > > * > > * Indicates that interrupt handling is enabled, specifically > > vblank > > * handling. Drivers which don't use drm_ir

Re: [PATCH 03/14] drm/atmel-hlcdc: Convert to Linux IRQ interfaces

2021-07-28 Thread Dan.Sneddon
On 7/28/21 7:00 AM, Sam Ravnborg wrote: > [You don't often get email from s...@ravnborg.org. Learn why this is > important at http://aka.ms/LearnAboutSenderIdentification.] > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Hi Dan, > > I hope y

Re: Re: [PATCH 03/14] drm/atmel-hlcdc: Convert to Linux IRQ interfaces

2021-07-28 Thread Sam Ravnborg
Hi Dan, > >> > >> Just to be sure... > >> Can you confirm that vbltest is working OK *before* this patch? > > > > Yes, can you please verify that it regressed. If so, this would mean > > that the driver misses vblank interrupts with the patch applied. > > Yes, unfortunately the vbltest works be

Re: [PATCH 03/14] drm/atmel-hlcdc: Convert to Linux IRQ interfaces

2021-07-28 Thread Thomas Zimmermann
Hi Am 28.07.21 um 20:11 schrieb Sam Ravnborg: Hi Dan, thanks for the quick feedback! On Wed, Jul 28, 2021 at 05:50:34PM +, dan.sned...@microchip.com wrote: On 7/28/21 8:44 AM, Sam Ravnborg wrote: EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Re: [PATCH 03/14] drm/atmel-hlcdc: Convert to Linux IRQ interfaces

2021-07-28 Thread Sam Ravnborg
Hi Dan, thanks for the quick feedback! On Wed, Jul 28, 2021 at 05:50:34PM +, dan.sned...@microchip.com wrote: > On 7/28/21 8:44 AM, Sam Ravnborg wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > > content is safe > > > > Hi Dan, > > > > On Wed, Jul 28,

Re: [PATCH 03/14] drm/atmel-hlcdc: Convert to Linux IRQ interfaces

2021-07-28 Thread Sam Ravnborg
Hi Dan, On Wed, Jul 28, 2021 at 03:11:08PM +, dan.sned...@microchip.com wrote: > On 7/28/21 7:00 AM, Sam Ravnborg wrote: > > [You don't often get email from s...@ravnborg.org. Learn why this is > > important at http://aka.ms/LearnAboutSenderIdentification.] > > > > EXTERNAL EMAIL: Do not cli

Re: [PATCH 03/14] drm/atmel-hlcdc: Convert to Linux IRQ interfaces

2021-07-28 Thread Sam Ravnborg
Hi Dan, I hope you can fine to test this patch from Thomas. If this works then we can forget about my attempt to do the same. Hi Thomas, IRQ_NOTCONNECTED check seems redundant, as mentioned in another patch already. With that considered: Reviewed-by: Sam Ravnborg We shall wait for testing fro

[PATCH 03/14] drm/atmel-hlcdc: Convert to Linux IRQ interfaces

2021-07-27 Thread Thomas Zimmermann
Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't benefit from using it. DRM IRQ callbacks are now being called directly or inlined. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcd