Re: [PATCH 03/12] mm/pagewalk: Skip dax pages in pagewalk

2025-06-12 Thread Alistair Popple
On Thu, Jun 12, 2025 at 03:15:31PM +0100, Lorenzo Stoakes wrote: > On Thu, May 29, 2025 at 04:32:04PM +1000, Alistair Popple wrote: > > Previously dax pages were skipped by the pagewalk code as pud_special() or > > vm_normal_page{_pmd}() would be false for DAX pages. Now that dax pages are > > refc

Re: [PATCH 03/12] mm/pagewalk: Skip dax pages in pagewalk

2025-06-12 Thread Lorenzo Stoakes
On Thu, May 29, 2025 at 04:32:04PM +1000, Alistair Popple wrote: > Previously dax pages were skipped by the pagewalk code as pud_special() or > vm_normal_page{_pmd}() would be false for DAX pages. Now that dax pages are > refcounted normally that is no longer the case, so add explicit checks to > s

Re: [PATCH 03/12] mm/pagewalk: Skip dax pages in pagewalk

2025-06-12 Thread Alistair Popple
On Thu, Jun 12, 2025 at 05:02:13PM +1000, Alistair Popple wrote: > On Thu, Jun 05, 2025 at 09:21:28AM -0700, Dan Williams wrote: > > David Hildenbrand wrote: > > > On 05.06.25 09:46, Christoph Hellwig wrote: > > > > On Wed, Jun 04, 2025 at 06:59:09PM -0700, Dan Williams wrote: > > > >> +/* return n

Re: [PATCH 03/12] mm/pagewalk: Skip dax pages in pagewalk

2025-06-12 Thread Alistair Popple
On Thu, Jun 05, 2025 at 09:21:28AM -0700, Dan Williams wrote: > David Hildenbrand wrote: > > On 05.06.25 09:46, Christoph Hellwig wrote: > > > On Wed, Jun 04, 2025 at 06:59:09PM -0700, Dan Williams wrote: > > >> +/* return normal pages backed by the page allocator */ > > >> +static inline struct pa

Re: [PATCH 03/12] mm/pagewalk: Skip dax pages in pagewalk

2025-06-05 Thread Dan Williams
David Hildenbrand wrote: > On 05.06.25 09:46, Christoph Hellwig wrote: > > On Wed, Jun 04, 2025 at 06:59:09PM -0700, Dan Williams wrote: > >> +/* return normal pages backed by the page allocator */ > >> +static inline struct page *vm_normal_gfp_pmd(struct vm_area_struct *vma, > >> +

Re: [PATCH 03/12] mm/pagewalk: Skip dax pages in pagewalk

2025-06-05 Thread David Hildenbrand
On 05.06.25 09:46, Christoph Hellwig wrote: On Wed, Jun 04, 2025 at 06:59:09PM -0700, Dan Williams wrote: +/* return normal pages backed by the page allocator */ +static inline struct page *vm_normal_gfp_pmd(struct vm_area_struct *vma, +unsigned long a

Re: [PATCH 03/12] mm/pagewalk: Skip dax pages in pagewalk

2025-06-05 Thread Christoph Hellwig
On Wed, Jun 04, 2025 at 06:59:09PM -0700, Dan Williams wrote: > +/* return normal pages backed by the page allocator */ > +static inline struct page *vm_normal_gfp_pmd(struct vm_area_struct *vma, > + unsigned long addr, pmd_t pmd) > +{ > + struct page *p

Re: [PATCH 03/12] mm/pagewalk: Skip dax pages in pagewalk

2025-06-04 Thread Dan Williams
Alistair Popple wrote: > Previously dax pages were skipped by the pagewalk code as pud_special() or > vm_normal_page{_pmd}() would be false for DAX pages. Now that dax pages are > refcounted normally that is no longer the case, so add explicit checks to > skip them. > > Signed-off-by: Alistair Pop

Re: [PATCH 03/12] mm/pagewalk: Skip dax pages in pagewalk

2025-06-03 Thread Jason Gunthorpe
On Thu, May 29, 2025 at 04:32:04PM +1000, Alistair Popple wrote: > Previously dax pages were skipped by the pagewalk code as pud_special() or > vm_normal_page{_pmd}() would be false for DAX pages. Now that dax pages are > refcounted normally that is no longer the case, so add explicit checks to > s

Re: [PATCH 03/12] mm/pagewalk: Skip dax pages in pagewalk

2025-05-30 Thread David Hildenbrand
On 29.05.25 08:32, Alistair Popple wrote: Previously dax pages were skipped by the pagewalk code as pud_special() or vm_normal_page{_pmd}() would be false for DAX pages. Now that dax pages are refcounted normally that is no longer the case, so add explicit checks to skip them. Is this really wh

[PATCH 03/12] mm/pagewalk: Skip dax pages in pagewalk

2025-05-28 Thread Alistair Popple
Previously dax pages were skipped by the pagewalk code as pud_special() or vm_normal_page{_pmd}() would be false for DAX pages. Now that dax pages are refcounted normally that is no longer the case, so add explicit checks to skip them. Signed-off-by: Alistair Popple --- include/linux/memremap.h