Re: [PATCH 03/11] fbdev/vga16fb: Auto-generate module init/exit code

2022-07-11 Thread Javier Martinez Canillas
On 7/11/22 10:01, Thomas Zimmermann wrote: > Hi > > Am 08.07.22 um 15:16 schrieb Javier Martinez Canillas: >> On 7/7/22 17:39, Thomas Zimmermann wrote: >>> Move vgag16fb's option parsing into the driver's probe function and >>> generate the rest of the module's init/exit functions from macros. >>>

Re: [PATCH 03/11] fbdev/vga16fb: Auto-generate module init/exit code

2022-07-11 Thread Thomas Zimmermann
Hi Am 08.07.22 um 15:16 schrieb Javier Martinez Canillas: On 7/7/22 17:39, Thomas Zimmermann wrote: Move vgag16fb's option parsing into the driver's probe function and generate the rest of the module's init/exit functions from macros. Keep the options code, although there are no options defined

Re: [PATCH 03/11] fbdev/vga16fb: Auto-generate module init/exit code

2022-07-08 Thread Javier Martinez Canillas
On 7/7/22 17:39, Thomas Zimmermann wrote: > Move vgag16fb's option parsing into the driver's probe function and > generate the rest of the module's init/exit functions from macros. > Keep the options code, although there are no options defined. > Ah, I see now why you wanted to move the check to t

[PATCH 03/11] fbdev/vga16fb: Auto-generate module init/exit code

2022-07-07 Thread Thomas Zimmermann
Move vgag16fb's option parsing into the driver's probe function and generate the rest of the module's init/exit functions from macros. Keep the options code, although there are no options defined. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/vga16fb.c | 35 ++-