Re: [PATCH 02/64] drm/crtc: Introduce drmm_crtc_init_with_planes

On Wed, Jun 15, 2022 at 12:34:46PM +0200, Thomas Zimmermann wrote: > Hi > > Am 15.06.22 um 10:32 schrieb Maxime Ripard: > [...] > > > See, helpers should be useful to many drivers. If we add them, we also > > > add a > > > resources and maintenance overhead to our libraries. And right now, these

Re: [PATCH 02/64] drm/crtc: Introduce drmm_crtc_init_with_planes

Hi Am 15.06.22 um 10:32 schrieb Maxime Ripard: [...] See, helpers should be useful to many drivers. If we add them, we also add a resources and maintenance overhead to our libraries. And right now, these new functions appear to work around the design of the vc4 driver's data structures. If you

Re: [PATCH 02/64] drm/crtc: Introduce drmm_crtc_init_with_planes

On Wed, Jun 15, 2022 at 09:22:55AM +0200, Thomas Zimmermann wrote: > Hi > > Am 14.06.22 um 14:09 schrieb Maxime Ripard: > > On Tue, Jun 14, 2022 at 01:47:28PM +0200, Thomas Zimmermann wrote: > > > Am 14.06.22 um 11:04 schrieb Maxime Ripard: > > > > On Tue, Jun 14, 2022 at 10:29:20AM +0200, Thomas

Re: [PATCH 02/64] drm/crtc: Introduce drmm_crtc_init_with_planes

Hi Am 14.06.22 um 14:09 schrieb Maxime Ripard: On Tue, Jun 14, 2022 at 01:47:28PM +0200, Thomas Zimmermann wrote: Am 14.06.22 um 11:04 schrieb Maxime Ripard: On Tue, Jun 14, 2022 at 10:29:20AM +0200, Thomas Zimmermann wrote: Am 14.06.22 um 09:37 schrieb Maxime Ripard: Hi Thomas, On Mon, Jun

Re: [PATCH 02/64] drm/crtc: Introduce drmm_crtc_init_with_planes

On Tue, Jun 14, 2022 at 01:47:28PM +0200, Thomas Zimmermann wrote: > Am 14.06.22 um 11:04 schrieb Maxime Ripard: > > On Tue, Jun 14, 2022 at 10:29:20AM +0200, Thomas Zimmermann wrote: > > > Am 14.06.22 um 09:37 schrieb Maxime Ripard: > > > > Hi Thomas, > > > > > > > > On Mon, Jun 13, 2022 at 01:23

Re: [PATCH 02/64] drm/crtc: Introduce drmm_crtc_init_with_planes

Hi Maxime Am 14.06.22 um 11:04 schrieb Maxime Ripard: On Tue, Jun 14, 2022 at 10:29:20AM +0200, Thomas Zimmermann wrote: Hi Am 14.06.22 um 09:37 schrieb Maxime Ripard: Hi Thomas, On Mon, Jun 13, 2022 at 01:23:54PM +0200, Thomas Zimmermann wrote: Am 10.06.22 um 11:28 schrieb Maxime Ripard:

Re: [PATCH 02/64] drm/crtc: Introduce drmm_crtc_init_with_planes

On Tue, Jun 14, 2022 at 10:29:20AM +0200, Thomas Zimmermann wrote: > Hi > > Am 14.06.22 um 09:37 schrieb Maxime Ripard: > > Hi Thomas, > > > > On Mon, Jun 13, 2022 at 01:23:54PM +0200, Thomas Zimmermann wrote: > > > Am 10.06.22 um 11:28 schrieb Maxime Ripard: > > > > The DRM-managed function to r

Re: [PATCH 02/64] drm/crtc: Introduce drmm_crtc_init_with_planes

Hi Am 14.06.22 um 09:37 schrieb Maxime Ripard: Hi Thomas, On Mon, Jun 13, 2022 at 01:23:54PM +0200, Thomas Zimmermann wrote: Am 10.06.22 um 11:28 schrieb Maxime Ripard: The DRM-managed function to register a CRTC is drmm_crtc_alloc_with_planes(), which will allocate the underlying structure a

Re: [PATCH 02/64] drm/crtc: Introduce drmm_crtc_init_with_planes

Hi Thomas, On Mon, Jun 13, 2022 at 01:23:54PM +0200, Thomas Zimmermann wrote: > Am 10.06.22 um 11:28 schrieb Maxime Ripard: > > The DRM-managed function to register a CRTC is > > drmm_crtc_alloc_with_planes(), which will allocate the underlying > > structure and initialisation the CRTC. > > > > H

Re: [PATCH 02/64] drm/crtc: Introduce drmm_crtc_init_with_planes

Hi Maxime Am 10.06.22 um 11:28 schrieb Maxime Ripard: The DRM-managed function to register a CRTC is drmm_crtc_alloc_with_planes(), which will allocate the underlying structure and initialisation the CRTC. However, we might want to separate the structure creation and the CRTC initialisation, fo

[PATCH 02/64] drm/crtc: Introduce drmm_crtc_init_with_planes

The DRM-managed function to register a CRTC is drmm_crtc_alloc_with_planes(), which will allocate the underlying structure and initialisation the CRTC. However, we might want to separate the structure creation and the CRTC initialisation, for example if the structure is shared across multiple DRM