[PATCH 02/21] drm/i915: Shut down PCH interrupts during irq_uninstall

2011-09-30 Thread Daniel Vetter
On Fri, Sep 30, 2011 at 10:44:22AM -0700, Keith Packard wrote: > On Fri, 30 Sep 2011 18:20:48 +0200, Daniel Vetter wrote: > > > Shouldn't we mask/ack south DE irqs before before we mask DE irqs to avoid > > races, i.e. move this new code up? > > I don't know. What about the GT interrupts? I jus

[PATCH 02/21] drm/i915: Shut down PCH interrupts during irq_uninstall

2011-09-30 Thread Daniel Vetter
On Thu, Sep 29, 2011 at 06:09:34PM -0700, Keith Packard wrote: > This masks out all interrupts and ack's any pending ones at IRQ > uninstall time to make sure we don't receive any unexpected interrupts > later on. > > Signed-off-by: Keith Packard > --- > drivers/gpu/drm/i915/i915_irq.c |4 ++

Re: [PATCH 02/21] drm/i915: Shut down PCH interrupts during irq_uninstall

2011-09-30 Thread Daniel Vetter
On Fri, Sep 30, 2011 at 10:44:22AM -0700, Keith Packard wrote: > On Fri, 30 Sep 2011 18:20:48 +0200, Daniel Vetter wrote: > > > Shouldn't we mask/ack south DE irqs before before we mask DE irqs to avoid > > races, i.e. move this new code up? > > I don't know. What about the GT interrupts? I jus

Re: [PATCH 02/21] drm/i915: Shut down PCH interrupts during irq_uninstall

2011-09-30 Thread Keith Packard
On Fri, 30 Sep 2011 18:20:48 +0200, Daniel Vetter wrote: > Shouldn't we mask/ack south DE irqs before before we mask DE irqs to avoid > races, i.e. move this new code up? I don't know. What about the GT interrupts? I just stuck stuff at the bottom, figuring it would do the least harm... -- ke

[PATCH 02/21] drm/i915: Shut down PCH interrupts during irq_uninstall

2011-09-30 Thread Keith Packard
On Fri, 30 Sep 2011 18:20:48 +0200, Daniel Vetter wrote: > Shouldn't we mask/ack south DE irqs before before we mask DE irqs to avoid > races, i.e. move this new code up? I don't know. What about the GT interrupts? I just stuck stuff at the bottom, figuring it would do the least harm... -- ke

Re: [PATCH 02/21] drm/i915: Shut down PCH interrupts during irq_uninstall

2011-09-30 Thread Daniel Vetter
On Thu, Sep 29, 2011 at 06:09:34PM -0700, Keith Packard wrote: > This masks out all interrupts and ack's any pending ones at IRQ > uninstall time to make sure we don't receive any unexpected interrupts > later on. > > Signed-off-by: Keith Packard > --- > drivers/gpu/drm/i915/i915_irq.c |4 ++

[PATCH 02/21] drm/i915: Shut down PCH interrupts during irq_uninstall

2011-09-29 Thread Keith Packard
This masks out all interrupts and ack's any pending ones at IRQ uninstall time to make sure we don't receive any unexpected interrupts later on. Signed-off-by: Keith Packard --- drivers/gpu/drm/i915/i915_irq.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/gp

[PATCH 02/21] drm/i915: Shut down PCH interrupts during irq_uninstall

2011-09-29 Thread Keith Packard
This masks out all interrupts and ack's any pending ones at IRQ uninstall time to make sure we don't receive any unexpected interrupts later on. Signed-off-by: Keith Packard --- drivers/gpu/drm/i915/i915_irq.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/gp