Re: [PATCH 02/14] drm/mgag200: Move DAC-register setup into model-specific code

2022-07-11 Thread Thomas Zimmermann
Hi Sam Am 08.07.22 um 17:54 schrieb Sam Ravnborg: Hi Thomas, On Fri, Jul 08, 2022 at 11:39:17AM +0200, Thomas Zimmermann wrote: Provide an init function for each model's DAC registers. Remove the shared helper. The code for initializing the DAC registers consisted of a large table of default

Re: [PATCH 02/14] drm/mgag200: Move DAC-register setup into model-specific code

2022-07-08 Thread Sam Ravnborg
Hi Thomas, On Fri, Jul 08, 2022 at 11:39:17AM +0200, Thomas Zimmermann wrote: > Provide an init function for each model's DAC registers. Remove > the shared helper. > > The code for initializing the DAC registers consisted of a large > table of default value, plus many exceptions for the various

[PATCH 02/14] drm/mgag200: Move DAC-register setup into model-specific code

2022-07-08 Thread Thomas Zimmermann
Provide an init function for each model's DAC registers. Remove the shared helper. The code for initializing the DAC registers consisted of a large table of default value, plus many exceptions for the various G200 models. Providing a per-model implementation makes if more readable. At some point,