[PATCH 02/14] drm/exynos: Remove exynos_plane_dpms() call with no effect

2015-02-05 Thread Joonyoung Shim
Hi Daniel, On 02/04/2015 11:16 PM, Daniel Vetter wrote: > On Wed, Feb 04, 2015 at 04:42:57PM +0900, Joonyoung Shim wrote: >> Hi, >> >> On 02/04/2015 04:14 AM, Gustavo Padovan wrote: >>> From: Gustavo Padovan >>> >>> exynos_plane_dpms(DRM_MODE_DPMS_ON) calls the win_enable()'s callback >>> from th

[PATCH 02/14] drm/exynos: Remove exynos_plane_dpms() call with no effect

2015-02-05 Thread Daniel Vetter
On Thu, Feb 05, 2015 at 10:05:43AM +0900, Joonyoung Shim wrote: > Hi Daniel, > > On 02/04/2015 11:16 PM, Daniel Vetter wrote: > > On Wed, Feb 04, 2015 at 04:42:57PM +0900, Joonyoung Shim wrote: > >> Hi, > >> > >> On 02/04/2015 04:14 AM, Gustavo Padovan wrote: > >>> From: Gustavo Padovan > >>> > >

[PATCH 02/14] drm/exynos: Remove exynos_plane_dpms() call with no effect

2015-02-04 Thread Joonyoung Shim
Hi, On 02/04/2015 04:14 AM, Gustavo Padovan wrote: > From: Gustavo Padovan > > exynos_plane_dpms(DRM_MODE_DPMS_ON) calls the win_enable()'s callback > from the underlying layer. However neither one of these layers implement > win_enable() - FIMD, Mixer and VIDI. Thus the call to exynos_plane_dpm

[PATCH 02/14] drm/exynos: Remove exynos_plane_dpms() call with no effect

2015-02-04 Thread Daniel Vetter
On Wed, Feb 04, 2015 at 04:42:57PM +0900, Joonyoung Shim wrote: > Hi, > > On 02/04/2015 04:14 AM, Gustavo Padovan wrote: > > From: Gustavo Padovan > > > > exynos_plane_dpms(DRM_MODE_DPMS_ON) calls the win_enable()'s callback > > from the underlying layer. However neither one of these layers impl

[PATCH 02/14] drm/exynos: Remove exynos_plane_dpms() call with no effect

2015-02-03 Thread Gustavo Padovan
From: Gustavo Padovan exynos_plane_dpms(DRM_MODE_DPMS_ON) calls the win_enable()'s callback from the underlying layer. However neither one of these layers implement win_enable() - FIMD, Mixer and VIDI. Thus the call to exynos_plane_dpms() is pointless. Signed-off-by: Gustavo Padovan --- driver