Re: [PATCH 02/13] amdgpu: don't initialize range->list in amdgpu_hmm_init_range

2019-08-02 Thread Jason Gunthorpe
On Wed, Jul 31, 2019 at 01:25:06PM +, Kuehling, Felix wrote: > On 2019-07-30 1:51 a.m., Christoph Hellwig wrote: > > The list is used to add the range to another list as an entry in the > > core hmm code, so there is no need to initialize it in a driver. > > I've seen code that uses list_empty

Re: [PATCH 02/13] amdgpu: don't initialize range->list in amdgpu_hmm_init_range

2019-07-31 Thread Kuehling, Felix
On 2019-07-30 1:51 a.m., Christoph Hellwig wrote: > The list is used to add the range to another list as an entry in the > core hmm code, so there is no need to initialize it in a driver. I've seen code that uses list_empty to check whether a list head has been added to a list or not. For that to

Re: [PATCH 02/13] amdgpu: don't initialize range->list in amdgpu_hmm_init_range

2019-07-31 Thread Jason Gunthorpe
On Tue, Jul 30, 2019 at 08:51:52AM +0300, Christoph Hellwig wrote: > The list is used to add the range to another list as an entry in the > core hmm code, so there is no need to initialize it in a driver. > > Signed-off-by: Christoph Hellwig > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c | 1 - >