Re: [PATCH 02/10] phy: Add configuration interface

2018-09-25 Thread Kishon Vijay Abraham I
Hi Maxime, On Wednesday 19 September 2018 05:44 PM, Maxime Ripard wrote: > Hi, > > On Fri, Sep 14, 2018 at 02:18:37PM +0530, Kishon Vijay Abraham I wrote: >>> +/** >>> + * phy_validate() - Checks the phy parameters >>> + * @phy: the phy returned by phy_get() >>> + * @mode: phy_mod

Re: [PATCH 02/10] phy: Add configuration interface

2018-09-25 Thread Kishon Vijay Abraham I
Hi Maxime, On Monday 24 September 2018 03:24 PM, Maxime Ripard wrote: > Hi, > > On Mon, Sep 24, 2018 at 02:18:35PM +0530, Kishon Vijay Abraham I wrote: >> On Wednesday 19 September 2018 05:44 PM, Maxime Ripard wrote: >>> Hi, >>> >>> On Fri, Sep 14, 2018 at 02:18:37PM +0530, Kishon Vijay Abraham I

Re: [PATCH 02/10] phy: Add configuration interface

2018-09-24 Thread Maxime Ripard
Hi! (stripping the mail a bit) On Mon, Sep 24, 2018 at 05:25:26PM +0530, Kishon Vijay Abraham I wrote: > > This integration will prevent us to use some clock rates on the first > > SoC, while the second one would be totally fine with it. > > If there's a clock that is fed to the

Re: [PATCH 02/10] phy: Add configuration interface

2018-09-24 Thread Maxime Ripard
Hi, On Mon, Sep 24, 2018 at 02:18:35PM +0530, Kishon Vijay Abraham I wrote: > On Wednesday 19 September 2018 05:44 PM, Maxime Ripard wrote: > > Hi, > > > > On Fri, Sep 14, 2018 at 02:18:37PM +0530, Kishon Vijay Abraham I wrote: > >>> +/** > >>> + * phy_validate() - Checks the phy paramete

Re: [PATCH 02/10] phy: Add configuration interface

2018-09-21 Thread Maxime Ripard
On Wed, Sep 19, 2018 at 02:14:36PM +0200, Maxime Ripard wrote: > > I'm sorry but I'm not convinced a consumer driver should have all the > > details > > that are added in phy_configure_opts_mipi_dphy. > > If it can convince you, here is the parameters that are needed by all > the MIPI-DSI drivers

Re: [PATCH 02/10] phy: Add configuration interface

2018-09-19 Thread Maxime Ripard
Hi, On Fri, Sep 14, 2018 at 02:18:37PM +0530, Kishon Vijay Abraham I wrote: > > +/** > > + * phy_validate() - Checks the phy parameters > > + * @phy: the phy returned by phy_get() > > + * @mode: phy_mode the configuration is applicable to. > > + * @opts: Configuration to check

Re: [PATCH 02/10] phy: Add configuration interface

2018-09-14 Thread Kishon Vijay Abraham I
Hi Maxime, On Wednesday 12 September 2018 02:12 PM, Maxime Ripard wrote: > Hi! > > On Wed, Sep 12, 2018 at 01:12:31PM +0530, Kishon Vijay Abraham I wrote: >> On Thursday 06 September 2018 08:26 PM, Maxime Ripard wrote: >>> Hi Kishon, >>> >>> On Thu, Sep 06, 2018 at 02:57:58PM +0530, Kishon Vijay

Re: [PATCH 02/10] phy: Add configuration interface

2018-09-13 Thread Kishon Vijay Abraham I
Hi, On Thursday 06 September 2018 08:26 PM, Maxime Ripard wrote: > Hi Kishon, > > On Thu, Sep 06, 2018 at 02:57:58PM +0530, Kishon Vijay Abraham I wrote: >> On Wednesday 05 September 2018 02:46 PM, Maxime Ripard wrote: >>> The phy framework is only allowing to configure the power state of the PHY

Re: [PATCH 02/10] phy: Add configuration interface

2018-09-12 Thread Maxime Ripard
Hi! On Wed, Sep 12, 2018 at 01:12:31PM +0530, Kishon Vijay Abraham I wrote: > On Thursday 06 September 2018 08:26 PM, Maxime Ripard wrote: > > Hi Kishon, > > > > On Thu, Sep 06, 2018 at 02:57:58PM +0530, Kishon Vijay Abraham I wrote: > >> On Wednesday 05 September 2018 02:46 PM, Maxime Ripard wro

Re: [PATCH 02/10] phy: Add configuration interface

2018-09-07 Thread Maxime Ripard
On Thu, Sep 06, 2018 at 07:51:05PM +0300, Laurent Pinchart wrote: > On Thursday, 6 September 2018 17:48:07 EEST Maxime Ripard wrote: > > On Wed, Sep 05, 2018 at 04:39:46PM +0300, Laurent Pinchart wrote: > > > On Wednesday, 5 September 2018 12:16:33 EEST Maxime Ripard wrote: > > >> The phy framework

Re: [PATCH 02/10] phy: Add configuration interface

2018-09-07 Thread Maxime Ripard
On Thu, Sep 06, 2018 at 06:24:50PM +0200, Andrew Lunn wrote: > > > > +int phy_configure(struct phy *phy, enum phy_mode mode, > > > > + union phy_configure_opts *opts) > > > > +{ > > > > + int ret; > > > > + > > > > + if (!phy) > > > > + return -EINVAL; > >

Re: [PATCH 02/10] phy: Add configuration interface

2018-09-07 Thread Kishon Vijay Abraham I
Hi, On Wednesday 05 September 2018 02:46 PM, Maxime Ripard wrote: > The phy framework is only allowing to configure the power state of the PHY > using the init and power_on hooks, and their power_off and exit > counterparts. > > While it works for most, simple, PHYs supported so far, some more ad

Re: [PATCH 02/10] phy: Add configuration interface

2018-09-06 Thread Andrew Lunn
> > > +int phy_configure(struct phy *phy, enum phy_mode mode, > > > + union phy_configure_opts *opts) > > > +{ > > > + int ret; > > > + > > > + if (!phy) > > > + return -EINVAL; > > > + > > > + if (!phy->ops->configure) > > > + return 0; > > > > Shouldn't you report an er

Re: [PATCH 02/10] phy: Add configuration interface

2018-09-06 Thread Laurent Pinchart
Hi Maxime, On Thursday, 6 September 2018 17:48:07 EEST Maxime Ripard wrote: > On Wed, Sep 05, 2018 at 04:39:46PM +0300, Laurent Pinchart wrote: > > On Wednesday, 5 September 2018 12:16:33 EEST Maxime Ripard wrote: > >> The phy framework is only allowing to configure the power state of the > >> PHY

Re: [PATCH 02/10] phy: Add configuration interface

2018-09-06 Thread Maxime Ripard
Hi Kishon, On Thu, Sep 06, 2018 at 02:57:58PM +0530, Kishon Vijay Abraham I wrote: > On Wednesday 05 September 2018 02:46 PM, Maxime Ripard wrote: > > The phy framework is only allowing to configure the power state of the PHY > > using the init and power_on hooks, and their power_off and exit > >

Re: [PATCH 02/10] phy: Add configuration interface

2018-09-06 Thread Maxime Ripard
On Wed, Sep 05, 2018 at 04:39:46PM +0300, Laurent Pinchart wrote: > Hi Maxime, > > Thank you for the patch. > > On Wednesday, 5 September 2018 12:16:33 EEST Maxime Ripard wrote: > > The phy framework is only allowing to configure the power state of the PHY > > using the init and power_on hooks, a

Re: [PATCH 02/10] phy: Add configuration interface

2018-09-05 Thread Laurent Pinchart
Hi Maxime, Thank you for the patch. On Wednesday, 5 September 2018 12:16:33 EEST Maxime Ripard wrote: > The phy framework is only allowing to configure the power state of the PHY > using the init and power_on hooks, and their power_off and exit > counterparts. > > While it works for most, simple

[PATCH 02/10] phy: Add configuration interface

2018-09-05 Thread Maxime Ripard
The phy framework is only allowing to configure the power state of the PHY using the init and power_on hooks, and their power_off and exit counterparts. While it works for most, simple, PHYs supported so far, some more advanced PHYs need some configuration depending on runtime parameters. These PH