Re: [PATCH 02/10] drm: crc: Introduce get_crc_sources callback

2018-07-12 Thread Laurent Pinchart
Hi Mahesh, Thank you for the patch. On Thursday, 12 July 2018 11:36:27 EEST Mahesh Kumar wrote: > This patch introduce a callback function "get_crc_sources" which > will be called during read of control node. It is an optional > callback function and if driver implements this callback, driver > s

[PATCH 02/10] drm: crc: Introduce get_crc_sources callback

2018-07-12 Thread Mahesh Kumar
This patch introduce a callback function "get_crc_sources" which will be called during read of control node. It is an optional callback function and if driver implements this callback, driver should return a constant pointer to an array of crc sources list and update count according to the number o

[PATCH 02/10] drm: crc: Introduce get_crc_sources callback

2018-07-11 Thread Mahesh Kumar
This patch introduce a callback function "get_crc_sources" which will be called during read of control node. It is an optional callback function and if driver implements this callback, driver should return a constant pointer to an array of crc sources list and update count according to the number o

Re: [PATCH 02/10] drm: crc: Introduce get_crc_sources callback

2018-07-10 Thread Kumar, Mahesh
Hi, On 7/10/2018 5:39 PM, Laurent Pinchart wrote: Hi Mahesh, On Tuesday, 10 July 2018 15:01:38 EEST Kumar, Mahesh wrote: On 7/10/2018 4:52 PM, Laurent Pinchart wrote: Hi Mahesh, On Monday, 2 July 2018 14:07:21 EEST Mahesh Kumar wrote: This patch introduce a callback function "get_crc_source

Re: [PATCH 02/10] drm: crc: Introduce get_crc_sources callback

2018-07-10 Thread Laurent Pinchart
Hi Mahesh, On Tuesday, 10 July 2018 15:01:38 EEST Kumar, Mahesh wrote: > On 7/10/2018 4:52 PM, Laurent Pinchart wrote: > > Hi Mahesh, > > On Monday, 2 July 2018 14:07:21 EEST Mahesh Kumar wrote: > >> This patch introduce a callback function "get_crc_sources" which > >> will be called during read o

Re: [PATCH 02/10] drm: crc: Introduce get_crc_sources callback

2018-07-10 Thread Kumar, Mahesh
Hi, thanks for the review. On 7/10/2018 4:52 PM, Laurent Pinchart wrote: Hi Mahesh, Thank you for the patch. On Monday, 2 July 2018 14:07:21 EEST Mahesh Kumar wrote: This patch introduce a callback function "get_crc_sources" which will be called during read of control node. It is an optional

Re: [PATCH 02/10] drm: crc: Introduce get_crc_sources callback

2018-07-10 Thread Laurent Pinchart
Hi Mahesh, Thank you for the patch. On Monday, 2 July 2018 14:07:21 EEST Mahesh Kumar wrote: > This patch introduce a callback function "get_crc_sources" which > will be called during read of control node. It is an optional > callback function and if driver implements this callback, driver > shou

[PATCH 02/10] drm: crc: Introduce get_crc_sources callback

2018-07-02 Thread Mahesh Kumar
This patch introduce a callback function "get_crc_sources" which will be called during read of control node. It is an optional callback function and if driver implements this callback, driver should print list of available CRC sources in seq_file privided as an input to the callback. Changes Since