Re: [PATCH 01/59] drm: Add devm_drm_dev_alloc macro

2020-04-28 Thread Daniel Vetter
On Tue, Apr 21, 2020 at 10:32:45PM +0200, Sam Ravnborg wrote: > Hi > > > > Hm, I see the point of this (and the dev_field below, although I'd go > > > with dev_member there for some consistency with other macros using > > > offset_of or container_of), but I'm not sure about the dev_ prefix. > > >

Re: [PATCH 01/59] drm: Add devm_drm_dev_alloc macro

2020-04-21 Thread Sam Ravnborg
Hi > > Hm, I see the point of this (and the dev_field below, although I'd go > > with dev_member there for some consistency with other macros using > > offset_of or container_of), but I'm not sure about the dev_ prefix. > > Drivers use that sometimes for the struct device *, and usage for > > stru

Re: [PATCH 01/59] drm: Add devm_drm_dev_alloc macro

2020-04-21 Thread Thomas Zimmermann
Hi Am 21.04.20 um 12:45 schrieb Daniel Vetter: > On Mon, Apr 20, 2020 at 3:37 PM Thomas Zimmermann wrote: >> >> Hi >> >> Am 15.04.20 um 09:39 schrieb Daniel Vetter: >>> Add a new macro helper to combine the usual init sequence in drivers, >>> consisting of a kzalloc + devm_drm_dev_init + drmm_add

Re: [PATCH 01/59] drm: Add devm_drm_dev_alloc macro

2020-04-21 Thread Daniel Vetter
On Mon, Apr 20, 2020 at 3:37 PM Thomas Zimmermann wrote: > > Hi > > Am 15.04.20 um 09:39 schrieb Daniel Vetter: > > Add a new macro helper to combine the usual init sequence in drivers, > > consisting of a kzalloc + devm_drm_dev_init + drmm_add_final_kfree > > triplet. This allows us to remove the

Re: [PATCH 01/59] drm: Add devm_drm_dev_alloc macro

2020-04-20 Thread Thomas Zimmermann
Hi Am 15.04.20 um 09:39 schrieb Daniel Vetter: > Add a new macro helper to combine the usual init sequence in drivers, > consisting of a kzalloc + devm_drm_dev_init + drmm_add_final_kfree > triplet. This allows us to remove the rather unsightly > drmm_add_final_kfree from all currently merged driv

[PATCH 01/59] drm: Add devm_drm_dev_alloc macro

2020-04-15 Thread Daniel Vetter
Add a new macro helper to combine the usual init sequence in drivers, consisting of a kzalloc + devm_drm_dev_init + drmm_add_final_kfree triplet. This allows us to remove the rather unsightly drmm_add_final_kfree from all currently merged drivers. The kerneldoc is only added for this new function.