Re: [PATCH 01/34] drm: Convert drm_minors_idr to XArray

2019-02-25 Thread Matthew Wilcox
On Fri, Feb 22, 2019 at 10:11:14AM +0100, Daniel Vetter wrote: > On Thu, Feb 21, 2019 at 10:41:21AM -0800, Matthew Wilcox wrote: > > Divide all the indices by 64 to save memory. > > > > Signed-off-by: Matthew Wilcox > > Pretty sure this goes boom. Our char device minor allocation scheme is > >

Re: [PATCH 01/34] drm: Convert drm_minors_idr to XArray

2019-02-22 Thread Daniel Vetter
On Fri, Feb 22, 2019 at 10:11:14AM +0100, Daniel Vetter wrote: > On Thu, Feb 21, 2019 at 10:41:21AM -0800, Matthew Wilcox wrote: > > Divide all the indices by 64 to save memory. > > > > Signed-off-by: Matthew Wilcox > > Pretty sure this goes boom. Our char device minor allocation scheme is > >

Re: [PATCH 01/34] drm: Convert drm_minors_idr to XArray

2019-02-22 Thread Daniel Vetter
On Thu, Feb 21, 2019 at 10:41:21AM -0800, Matthew Wilcox wrote: > Divide all the indices by 64 to save memory. > > Signed-off-by: Matthew Wilcox Pretty sure this goes boom. Our char device minor allocation scheme is device 0: card0=0, renderD0=64 device 1: card1=1, renderD1=65 ... I think your

[PATCH 01/34] drm: Convert drm_minors_idr to XArray

2019-02-22 Thread Matthew Wilcox
Divide all the indices by 64 to save memory. Signed-off-by: Matthew Wilcox --- drivers/gpu/drm/drm_drv.c | 49 ++- 1 file changed, 17 insertions(+), 32 deletions(-) diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c index 12e5e2be7890..17ed29f