Re: [PATCH 01/22] drm/fbdev-dma: Implement fbdev emulation for GEM DMA helpers

2023-03-10 Thread Thomas Zimmermann
Hi Javier, thanks for your review. Am 09.03.23 um 12:04 schrieb Javier Martinez Canillas: Thomas Zimmermann writes: Implement fbdev emulation that is optimized for drivers that use DMA helpers. The buffers may no tbe moveable, may not require damage "may not be" Is may the correct verb he

Re: [PATCH 01/22] drm/fbdev-dma: Implement fbdev emulation for GEM DMA helpers

2023-03-09 Thread Javier Martinez Canillas
Javier Martinez Canillas writes: [...] >> +drm_fb_helper_prepare(dev, fb_helper, preferred_bpp, >> &drm_fbdev_dma_helper_funcs); >> + >> +ret = drm_client_init(dev, &fb_helper->client, "fbdev", >> &drm_fbdev_dma_client_funcs); >> +if (ret) { >> +drm_err(dev, "Failed to

Re: [PATCH 01/22] drm/fbdev-dma: Implement fbdev emulation for GEM DMA helpers

2023-03-09 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Implement fbdev emulation that is optimized for drivers that use > DMA helpers. The buffers may no tbe moveable, may not require damage "may not be" Is may the correct verb here though? I guess you meant "shall not". > handling and have to be located in system memor

[PATCH 01/22] drm/fbdev-dma: Implement fbdev emulation for GEM DMA helpers

2023-03-01 Thread Thomas Zimmermann
Implement fbdev emulation that is optimized for drivers that use DMA helpers. The buffers may no tbe moveable, may not require damage handling and have to be located in system memory. This allows fbdev emulation to operate directly on the buffer and mmap it to userspace. Besides those constraints,