Re: [PATCH 01/22] drm/arc: Use simple encoder

2020-03-09 Thread Thomas Zimmermann
Hi Sam Am 06.03.20 um 22:18 schrieb Sam Ravnborg: > On Thu, Mar 05, 2020 at 04:59:29PM +0100, Thomas Zimmermann wrote: >> The arc driver uses empty implementations for its encoders. Replace >> the code with the generic simple encoder. > > We should , as a follow-up patch, embed the encoder in > a

Re: [PATCH 01/22] drm/arc: Use simple encoder

2020-03-06 Thread Sam Ravnborg
On Thu, Mar 05, 2020 at 04:59:29PM +0100, Thomas Zimmermann wrote: > The arc driver uses empty implementations for its encoders. Replace > the code with the generic simple encoder. We should , as a follow-up patch, embed the encoder in arcgpu_drm_private. Then we drop the kzalloc() and avoid that

Re: [PATCH 01/22] drm/arc: Use simple encoder

2020-03-05 Thread kbuild test robot
Hi Thomas, I love your patch! Yet something to improve: [auto build test ERROR on next-20200305] [also build test ERROR on v5.6-rc4] [cannot apply to rockchip/for-next shawnguo/for-next sunxi/sunxi/for-next tegra/for-next linus/master v5.6-rc4 v5.6-rc3 v5.6-rc2] [if your patch is applied to the

[PATCH 01/22] drm/arc: Use simple encoder

2020-03-05 Thread Thomas Zimmermann
The arc driver uses empty implementations for its encoders. Replace the code with the generic simple encoder. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/arc/arcpgu_hdmi.c | 10 +++--- drivers/gpu/drm/arc/arcpgu_sim.c | 8 ++-- 2 files changed, 5 insertions(+), 13 deletions(-)