Re: [Intel-gfx] [PATCH 01/15] drm/kms-helpers: Use recommened kerneldoc for struct member refs

2017-01-25 Thread Daniel Vetter
On Wed, Jan 25, 2017 at 10:48:53AM -0200, Gustavo Padovan wrote: > Otherwise looks good to me: Nice catches, fixed them all and applied it. > > Rewiewed-by: Gustavo Padovan Thanks for your review. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch __

Re: [Intel-gfx] [PATCH 01/15] drm/kms-helpers: Use recommened kerneldoc for struct member refs

2017-01-25 Thread Gustavo Padovan
Hi Daniel, 2017-01-25 Daniel Vetter : > I just learned that &struct_name.member_name works and looks pretty > even. It doesn't (yet) link to the member directly though, which would > be really good for big structures or vfunc tables (where the > per-member kerneldoc tends to be long). > > Also s

[PATCH 01/15] drm/kms-helpers: Use recommened kerneldoc for struct member refs

2017-01-24 Thread Daniel Vetter
I just learned that &struct_name.member_name works and looks pretty even. It doesn't (yet) link to the member directly though, which would be really good for big structures or vfunc tables (where the per-member kerneldoc tends to be long). Also some minor drive-by polish where it makes sense, I re