Re: [PATCH 01/13] drm: execution context for GEM buffers v4

2023-06-21 Thread Christian König
Am 19.06.23 um 13:06 schrieb Thomas Hellström (Intel): On 6/19/23 11:48, Christian König wrote: Hi, Am 19.06.23 um 11:33 schrieb Thomas Hellström (Intel): [SNIP] Sometimes you want to just drop the contended lock after the above relaxation. (Eviction would be one example), and not add as pr

Re: [PATCH 01/13] drm: execution context for GEM buffers v4

2023-06-20 Thread Christian König
Am 20.06.23 um 08:47 schrieb Boris Brezillon: On Mon, 19 Jun 2023 14:29:23 +0200 Boris Brezillon wrote: On Mon, 19 Jun 2023 12:44:06 +0200 Christian König wrote: Am 19.06.23 um 12:12 schrieb Boris Brezillon: [SNIP] Note that the drm_exec_until_all_locked() helper I introduced is taking an

Re: [PATCH 01/13] drm: execution context for GEM buffers v4

2023-06-19 Thread Boris Brezillon
On Mon, 19 Jun 2023 14:29:23 +0200 Boris Brezillon wrote: > On Mon, 19 Jun 2023 12:44:06 +0200 > Christian König wrote: > > > Am 19.06.23 um 12:12 schrieb Boris Brezillon: > > > [SNIP] > > > Note that the drm_exec_until_all_locked() helper I introduced is taking > > > an expression, so in the

Re: [PATCH 01/13] drm: execution context for GEM buffers v4

2023-06-19 Thread Boris Brezillon
On Mon, 19 Jun 2023 12:44:06 +0200 Christian König wrote: > Am 19.06.23 um 12:12 schrieb Boris Brezillon: > > [SNIP] > > Note that the drm_exec_until_all_locked() helper I introduced is taking > > an expression, so in theory, you don't have to define a separate > > function. > > > > drm_exec_

Re: [PATCH 01/13] drm: execution context for GEM buffers v4

2023-06-19 Thread Boris Brezillon
On Mon, 19 Jun 2023 13:05:02 +0200 Boris Brezillon wrote: > On Mon, 19 Jun 2023 12:44:06 +0200 > Christian König wrote: > > > Am 19.06.23 um 12:12 schrieb Boris Brezillon: > > > [SNIP] > > > Note that the drm_exec_until_all_locked() helper I introduced is taking > > > an expression, so in the

Re: [PATCH 01/13] drm: execution context for GEM buffers v4

2023-06-19 Thread Intel
On 6/19/23 11:48, Christian König wrote: Hi, Am 19.06.23 um 11:33 schrieb Thomas Hellström (Intel): [SNIP] Sometimes you want to just drop the contended lock after the above relaxation. (Eviction would be one example), and not add as prelocked, if the contended object goes out of scope. Evi

Re: [PATCH 01/13] drm: execution context for GEM buffers v4

2023-06-19 Thread Boris Brezillon
On Mon, 19 Jun 2023 12:44:06 +0200 Christian König wrote: > Am 19.06.23 um 12:12 schrieb Boris Brezillon: > > [SNIP] > > Note that the drm_exec_until_all_locked() helper I introduced is taking > > an expression, so in theory, you don't have to define a separate > > function. > > > > drm_exec_

Re: [PATCH 01/13] drm: execution context for GEM buffers v4

2023-06-19 Thread Christian König
Am 19.06.23 um 12:12 schrieb Boris Brezillon: [SNIP] Note that the drm_exec_until_all_locked() helper I introduced is taking an expression, so in theory, you don't have to define a separate function. drm_exec_until_all_locked(&exec, { /* inlined-code */ in

Re: [PATCH 01/13] drm: execution context for GEM buffers v4

2023-06-19 Thread Boris Brezillon
On Mon, 19 Jun 2023 11:20:06 +0200 Christian König wrote: > Hi guys, > > Am 19.06.23 um 10:59 schrieb Thomas Hellström (Intel): > > [SNIP] > > I really need to find some time to work on that anyway. > >> I've been playing with drm_exec for a couple weeks now, and I wanted > >> to s

Re: [PATCH 01/13] drm: execution context for GEM buffers v4

2023-06-19 Thread Boris Brezillon
Hello Thomas, On Mon, 19 Jun 2023 10:59:16 +0200 Thomas Hellström (Intel) wrote: > > > +/** > > + * DOC: Overview > > + * > > + * This component mainly abstracts the retry loop necessary for locking > > + * multiple GEM objects while preparing hardware operations

Re: [PATCH 01/13] drm: execution context for GEM buffers v4

2023-06-19 Thread Christian König
Hi, Am 19.06.23 um 11:33 schrieb Thomas Hellström (Intel): [SNIP] Sometimes you want to just drop the contended lock after the above relaxation. (Eviction would be one example), and not add as prelocked, if the contended object goes out of scope. Eviction would in some situations be one such

Re: [PATCH 01/13] drm: execution context for GEM buffers v4

2023-06-19 Thread Intel
Hi! On 6/19/23 11:20, Christian König wrote: Hi guys, Am 19.06.23 um 10:59 schrieb Thomas Hellström (Intel): [SNIP] I really need to find some time to work on that anyway. I've been playing with drm_exec for a couple weeks now, and I wanted to share something I hacked to try and make the AP

Re: [PATCH 01/13] drm: execution context for GEM buffers v4

2023-06-19 Thread Christian König
Hi guys, Am 19.06.23 um 10:59 schrieb Thomas Hellström (Intel): [SNIP] I really need to find some time to work on that anyway. I've been playing with drm_exec for a couple weeks now, and I wanted to share something I hacked to try and make the API simpler and more robust against misuse (see t

Re: [PATCH 01/13] drm: execution context for GEM buffers v4

2023-06-19 Thread Intel
On 6/17/23 13:54, Boris Brezillon wrote: +Matthew who's been using drm_exec in Xe if I'm correct. Hello Christian, On Wed, 14 Jun 2023 15:02:52 +0200 Boris Brezillon wrote: On Wed, 14 Jun 2023 14:30:53 +0200 Christian König wrote: Am 14.06.23 um 14:23 schrieb Boris Brezillon: Hi Christ

Re: [PATCH 01/13] drm: execution context for GEM buffers v4

2023-06-17 Thread Boris Brezillon
+Matthew who's been using drm_exec in Xe if I'm correct. Hello Christian, On Wed, 14 Jun 2023 15:02:52 +0200 Boris Brezillon wrote: > On Wed, 14 Jun 2023 14:30:53 +0200 > Christian König wrote: > > > Am 14.06.23 um 14:23 schrieb Boris Brezillon: > > > Hi Christian, > > > > > > On Thu, 4 Ma

Re: [PATCH 01/13] drm: execution context for GEM buffers v4

2023-06-14 Thread Boris Brezillon
On Wed, 14 Jun 2023 14:30:53 +0200 Christian König wrote: > Am 14.06.23 um 14:23 schrieb Boris Brezillon: > > Hi Christian, > > > > On Thu, 4 May 2023 13:51:47 +0200 > > "Christian König" wrote: > > > >> This adds the infrastructure for an execution context for GEM buffers > >> which is simil

Re: [PATCH 01/13] drm: execution context for GEM buffers v4

2023-06-14 Thread Christian König
Am 14.06.23 um 14:23 schrieb Boris Brezillon: Hi Christian, On Thu, 4 May 2023 13:51:47 +0200 "Christian König" wrote: This adds the infrastructure for an execution context for GEM buffers which is similar to the existing TTMs execbuf util and intended to replace it in the long term. The

Re: [PATCH 01/13] drm: execution context for GEM buffers v4

2023-06-14 Thread Boris Brezillon
Hi Christian, On Thu, 4 May 2023 13:51:47 +0200 "Christian König" wrote: > This adds the infrastructure for an execution context for GEM buffers > which is similar to the existing TTMs execbuf util and intended to replace > it in the long term. > > The basic functionality is that we abstracts

Re: [PATCH 01/13] drm: execution context for GEM buffers v4

2023-05-25 Thread Danilo Krummrich
On 5/4/23 13:51, Christian König wrote: This adds the infrastructure for an execution context for GEM buffers which is similar to the existing TTMs execbuf util and intended to replace it in the long term. The basic functionality is that we abstracts the necessary loop to lock many different GEM

Re: [PATCH 01/13] drm: execution context for GEM buffers v4

2023-05-04 Thread Intel
On 5/4/23 13:51, Christian König wrote: This adds the infrastructure for an execution context for GEM buffers which is similar to the existing TTMs execbuf util and intended to replace it in the long term. The basic functionality is that we abstracts the necessary loop to lock many different G

[PATCH 01/13] drm: execution context for GEM buffers v4

2023-05-04 Thread Christian König
This adds the infrastructure for an execution context for GEM buffers which is similar to the existing TTMs execbuf util and intended to replace it in the long term. The basic functionality is that we abstracts the necessary loop to lock many different GEM buffers with automated deadlock and dupli