Re: (subset) [PATCH 01/10] drm/imagination: avoid unused-const-variable warning

2025-04-24 Thread Matt Coster
On Wed, 09 Apr 2025 14:22:53 +0200, Arnd Bergmann wrote: > When CONFIG_DEBUG_FS is disabled, the stid_fmts[] array is not referenced > anywhere, causing a W=1 warning with gcc: > > In file included from drivers/gpu/drm/imagination/pvr_fw_trace.c:7: > drivers/gpu/drm/imagination/pvr_rogue_fwif_sf

Re: [PATCH 01/10] drm/imagination: avoid unused-const-variable warning

2025-04-22 Thread Matt Coster
On 09/04/2025 13:22, Arnd Bergmann wrote: > From: Arnd Bergmann > > When CONFIG_DEBUG_FS is disabled, the stid_fmts[] array is not referenced > anywhere, causing a W=1 warning with gcc: > > In file included from drivers/gpu/drm/imagination/pvr_fw_trace.c:7: > drivers/gpu/drm/imagination/pvr_rogu

Re: [PATCH 01/10] drm/imagination: avoid unused-const-variable warning

2025-04-13 Thread Andy Shevchenko
On Thu, Apr 10, 2025 at 11:22:05AM +, Matt Coster wrote: > On 09/04/2025 13:22, Arnd Bergmann wrote: ... > > Rather than adding more #ifdef blocks, address this by changing the > > existing #ifdef into equivalent IS_ENABLED() checks so gcc can see > > where the symbol is used but still elimin

Re: [PATCH 01/10] drm/imagination: avoid unused-const-variable warning

2025-04-10 Thread Arnd Bergmann
On Thu, Apr 10, 2025, at 13:22, Matt Coster wrote: > On 09/04/2025 13:22, Arnd Bergmann wrote: >> >> Rather than adding more #ifdef blocks, address this by changing the >> existing #ifdef into equivalent IS_ENABLED() checks so gcc can see >> where the symbol is used but still eliminate it from the

Re: [PATCH 01/10] drm/imagination: avoid unused-const-variable warning

2025-04-10 Thread Jani Nikula
On Thu, 10 Apr 2025, Matt Coster wrote: > Having said that, surely it makes sense to keep at least > *_debugfs_init() gated behind CONFIG_DEBUG_FS? If they're basically just calls to debugfs_create_{dir,file}, the compiler pretty much turns them into nops, and you'll get better build coverage. B

Re: [PATCH 01/10] drm/imagination: avoid unused-const-variable warning

2025-04-10 Thread Matt Coster
On 09/04/2025 13:22, Arnd Bergmann wrote: > From: Arnd Bergmann > > When CONFIG_DEBUG_FS is disabled, the stid_fmts[] array is not referenced > anywhere, causing a W=1 warning with gcc: > > In file included from drivers/gpu/drm/imagination/pvr_fw_trace.c:7: > drivers/gpu/drm/imagination/pvr_rogu

[PATCH 01/10] drm/imagination: avoid unused-const-variable warning

2025-04-09 Thread Arnd Bergmann
From: Arnd Bergmann When CONFIG_DEBUG_FS is disabled, the stid_fmts[] array is not referenced anywhere, causing a W=1 warning with gcc: In file included from drivers/gpu/drm/imagination/pvr_fw_trace.c:7: drivers/gpu/drm/imagination/pvr_rogue_fwif_sf.h:75:39: error: 'stid_fmts' defined but not u