Re: [PATCH 00/22] Fallback to native backlight

2022-10-25 Thread Akihiko Odaki
On 2022/10/25 3:11, Jani Nikula wrote: On Tue, 25 Oct 2022, Akihiko Odaki wrote: That aside, the first patch in this series can be applied without the later patches so you may have a look at it. It's fine if you don't merge it though since it does not fix really a pragmatic bug as its message s

Re: [PATCH 00/22] Fallback to native backlight

2022-10-24 Thread Akihiko Odaki
On 2022/10/24 20:48, Jani Nikula wrote: On Mon, 24 Oct 2022, Akihiko Odaki wrote: Commit 2600bfa3df99 ("ACPI: video: Add acpi_video_backlight_use_native() helper") and following commits made native backlight unavailable if CONFIG_ACPI_VIDEO is set and the backlight feature of ACPI video is unav

Re: [PATCH 00/22] Fallback to native backlight

2022-10-24 Thread Akihiko Odaki
On 2022/10/24 20:53, Hans de Goede wrote: Hi Akihiko, On 10/24/22 13:34, Akihiko Odaki wrote: Commit 2600bfa3df99 ("ACPI: video: Add acpi_video_backlight_use_native() helper") and following commits made native backlight unavailable if CONFIG_ACPI_VIDEO is set and the backlight feature of ACPI v

Re: [PATCH 00/22] Fallback to native backlight

2022-10-24 Thread Akihiko Odaki
On 2022/10/24 22:21, Hans de Goede wrote: Hi, On 10/24/22 14:58, Akihiko Odaki wrote: On 2022/10/24 20:53, Hans de Goede wrote: Hi Akihiko, On 10/24/22 13:34, Akihiko Odaki wrote: Commit 2600bfa3df99 ("ACPI: video: Add acpi_video_backlight_use_native() helper") and following commits made nat

[PATCH 00/22] Fallback to native backlight

2022-10-24 Thread Akihiko Odaki
Commit 2600bfa3df99 ("ACPI: video: Add acpi_video_backlight_use_native() helper") and following commits made native backlight unavailable if CONFIG_ACPI_VIDEO is set and the backlight feature of ACPI video is unavailable, which broke the backlight functionality on Lenovo ThinkPad C13 Yoga Chromeboo

Re: [PATCH 00/22] Fallback to native backlight

2022-10-24 Thread Akihiko Odaki
On 2022/10/24 23:37, Hans de Goede wrote: Hi, On 10/24/22 16:31, Akihiko Odaki wrote: On 2022/10/24 23:06, Akihiko Odaki wrote: On 2022/10/24 22:21, Hans de Goede wrote: Hi, On 10/24/22 14:58, Akihiko Odaki wrote: On 2022/10/24 20:53, Hans de Goede wrote: Hi Akihiko, On 10/24/22 13:34,

Re: [PATCH 00/22] Fallback to native backlight

2022-10-24 Thread Akihiko Odaki
On 2022/10/24 23:06, Akihiko Odaki wrote: On 2022/10/24 22:21, Hans de Goede wrote: Hi, On 10/24/22 14:58, Akihiko Odaki wrote: On 2022/10/24 20:53, Hans de Goede wrote: Hi Akihiko, On 10/24/22 13:34, Akihiko Odaki wrote: Commit 2600bfa3df99 ("ACPI: video: Add acpi_video_backlight_use_nativ

Re: [PATCH 00/22] Fallback to native backlight

2022-10-24 Thread Jani Nikula
On Tue, 25 Oct 2022, Akihiko Odaki wrote: > That aside, the first patch in this series can be applied without the > later patches so you may have a look at it. It's fine if you don't merge > it though since it does not fix really a pragmatic bug as its message says. I think it's problematic bec

Re: [PATCH 00/22] Fallback to native backlight

2022-10-24 Thread Hans de Goede
Hi, On 10/24/22 16:31, Akihiko Odaki wrote: > On 2022/10/24 23:06, Akihiko Odaki wrote: >> On 2022/10/24 22:21, Hans de Goede wrote: >>> Hi, >>> >>> On 10/24/22 14:58, Akihiko Odaki wrote: On 2022/10/24 20:53, Hans de Goede wrote: > Hi Akihiko, > > On 10/24/22 13:34, Akihiko Odaki

Re: [PATCH 00/22] Fallback to native backlight

2022-10-24 Thread Hans de Goede
Hi, On 10/24/22 15:14, Pali Rohár wrote: > On Monday 24 October 2022 21:58:57 Akihiko Odaki wrote: >> Regarding the second limitation, I don't even understand the difference >> between vendor and native. My guess is that a vendor backlight device uses >> vendor-specific ACPI interface, and a nativ

Re: [PATCH 00/22] Fallback to native backlight

2022-10-24 Thread Hans de Goede
Hi, On 10/24/22 14:58, Akihiko Odaki wrote: > On 2022/10/24 20:53, Hans de Goede wrote: >> Hi Akihiko, >> >> On 10/24/22 13:34, Akihiko Odaki wrote: >>> Commit 2600bfa3df99 ("ACPI: video: Add acpi_video_backlight_use_native() >>> helper") and following commits made native backlight unavailable if

Re: [PATCH 00/22] Fallback to native backlight

2022-10-24 Thread Pali Rohár
On Monday 24 October 2022 21:58:57 Akihiko Odaki wrote: > Regarding the second limitation, I don't even understand the difference > between vendor and native. My guess is that a vendor backlight device uses > vendor-specific ACPI interface, and a native one directly uses hardware > registers. If my

Re: [PATCH 00/22] Fallback to native backlight

2022-10-24 Thread Hans de Goede
Hi, On 10/24/22 13:56, Akihiko Odaki wrote: > On 2022/10/24 20:48, Jani Nikula wrote: >> On Mon, 24 Oct 2022, Akihiko Odaki wrote: >>> Commit 2600bfa3df99 ("ACPI: video: Add acpi_video_backlight_use_native() >>> helper") and following commits made native backlight unavailable if >>> CONFIG_ACPI_V

Re: [PATCH 00/22] Fallback to native backlight

2022-10-24 Thread Hans de Goede
Hi Akihiko, On 10/24/22 13:34, Akihiko Odaki wrote: > Commit 2600bfa3df99 ("ACPI: video: Add acpi_video_backlight_use_native() > helper") and following commits made native backlight unavailable if > CONFIG_ACPI_VIDEO is set and the backlight feature of ACPI video is > unavailable, which broke the

Re: [PATCH 00/22] Fallback to native backlight

2022-10-24 Thread Jani Nikula
On Mon, 24 Oct 2022, Akihiko Odaki wrote: > Commit 2600bfa3df99 ("ACPI: video: Add acpi_video_backlight_use_native() > helper") and following commits made native backlight unavailable if > CONFIG_ACPI_VIDEO is set and the backlight feature of ACPI video is > unavailable, which broke the backlight