Re: [PATCH 00/17] drm: rename various struct members "dev" -> "drm"

2023-08-02 Thread Jani Nikula
On Thu, 13 Jul 2023, Jani Nikula wrote: > I find it obnoxious to send a new series within 24 hours of the first, > while the discussion is still in progress, and it's a misrepresentation > of the in-progress dicussion to say most of the feedback was positive. Uwe, all - Back from vacation. In th

Re: [PATCH 00/17] drm: rename various struct members "dev" -> "drm"

2023-07-14 Thread Paul Kocialkowski
Hi, On Thu 13 Jul 23, 16:10, Uwe Kleine-König wrote: > Hello Maxime, > > On Thu, Jul 13, 2023 at 01:17:43PM +0200, Maxime Ripard wrote: > > On Thu, Jul 13, 2023 at 12:39:40PM +0200, Uwe Kleine-König wrote: > > > On Thu, Jul 13, 2023 at 12:23:50PM +0300, Jani Nikula wrote: > > > > On Thu, 13 Jul

Re: [PATCH 00/17] drm: rename various struct members "dev" -> "drm"

2023-07-14 Thread Uwe Kleine-König
Hello Maxime, On Thu, Jul 13, 2023 at 05:47:54PM +0200, Maxime Ripard wrote: > So, on the record, we have 1 drm-misc maintainer, 1 intel GPU > maintainer, 1 amdgpu/radeon/dma-buf maintainer and one former drm-misc > maintainer pretty much against, or at best skeptical. And you don't have So now i

Re: [PATCH 00/17] drm: rename various struct members "dev" -> "drm"

2023-07-13 Thread Jani Nikula
On Thu, 13 Jul 2023, Uwe Kleine-König wrote: > - Jani Nikula >unnecessary change.(is this a "no" or a "don't care"?) >naming: drm > * Based on my replies, it's most certainly not "don't care"! ;D I would prefer not making the change. I avoided the blunt "no" to better leave room for dis

Re: [PATCH 00/17] drm: rename various struct members "dev" -> "drm"

2023-07-13 Thread Javier Martinez Canillas
Maxime Ripard writes: > On Thu, Jul 13, 2023 at 04:10:23PM +0200, Uwe Kleine-König wrote: [...] >> - Javier Martinez Canillas >>Generally in favour (also via irc) >>Wants a single patch >>naming: drm > drm_dev > dev > > drm-misc driver maintainer > Just to clarify my position on t

Re: [PATCH 00/17] drm: rename various struct members "dev" -> "drm"

2023-07-13 Thread Maxime Ripard
On Thu, Jul 13, 2023 at 04:10:23PM +0200, Uwe Kleine-König wrote: > On Thu, Jul 13, 2023 at 01:17:43PM +0200, Maxime Ripard wrote: > > On Thu, Jul 13, 2023 at 12:39:40PM +0200, Uwe Kleine-König wrote: > > > On Thu, Jul 13, 2023 at 12:23:50PM +0300, Jani Nikula wrote: > > > > On Thu, 13 Jul 2023, Uw

Re: [PATCH 00/17] drm: rename various struct members "dev" -> "drm"

2023-07-13 Thread Christian König
Am 13.07.23 um 16:10 schrieb Uwe Kleine-König: Hello Maxime, On Thu, Jul 13, 2023 at 01:17:43PM +0200, Maxime Ripard wrote: On Thu, Jul 13, 2023 at 12:39:40PM +0200, Uwe Kleine-König wrote: On Thu, Jul 13, 2023 at 12:23:50PM +0300, Jani Nikula wrote: On Thu, 13 Jul 2023, Uwe Kleine-König wro

Re: [PATCH 00/17] drm: rename various struct members "dev" -> "drm"

2023-07-13 Thread Thomas Zimmermann
Hi Am 13.07.23 um 16:10 schrieb Uwe Kleine-König: [...] - Thomas Zimmermann All data structures should be converted naming: drm > * [...]> I admit I'm not aware about the roles here, but up to then only Sean Paul wrote a clear no and maybe Jani Nikula a small one. I interpreted Paul

Re: [PATCH 00/17] drm: rename various struct members "dev" -> "drm"

2023-07-13 Thread Uwe Kleine-König
Hello Maxime, On Thu, Jul 13, 2023 at 01:17:43PM +0200, Maxime Ripard wrote: > On Thu, Jul 13, 2023 at 12:39:40PM +0200, Uwe Kleine-König wrote: > > On Thu, Jul 13, 2023 at 12:23:50PM +0300, Jani Nikula wrote: > > > On Thu, 13 Jul 2023, Uwe Kleine-König > > > wrote: > > > > after most feedback

Re: [PATCH 00/17] drm: rename various struct members "dev" -> "drm"

2023-07-13 Thread Thomas Zimmermann
Hi Am 13.07.23 um 15:11 schrieb Uwe Kleine-König: On Thu, Jul 13, 2023 at 12:41:15PM +0200, Thomas Zimmermann wrote: Hi Uwe Am 13.07.23 um 12:22 schrieb Uwe Kleine-König: [...] If that helps you: I plan to tackle these in a followup. I agree that's ugly, but fixing these in the same series i

Re: [PATCH 00/17] drm: rename various struct members "dev" -> "drm"

2023-07-13 Thread Paul Kocialkowski
Hi, On Thu 13 Jul 23, 14:05, Jani Nikula wrote: > On Thu, 13 Jul 2023, Uwe Kleine-König wrote: > > If you say you consider the idea bad or too costly to implement, that's > > fine. But pointing to other areas that are bad shouldn't be a relevant > > reason to shoot down this effort. > > I did no

Re: [PATCH 00/17] drm: rename various struct members "dev" -> "drm"

2023-07-13 Thread Uwe Kleine-König
On Thu, Jul 13, 2023 at 12:41:15PM +0200, Thomas Zimmermann wrote: > Hi Uwe > > Am 13.07.23 um 12:22 schrieb Uwe Kleine-König: > [...] > > > > If that helps you: I plan to tackle these in a followup. I agree that's > > ugly, but fixing these in the same series is too much and if we agree > > that

Re: [PATCH 00/17] drm: rename various struct members "dev" -> "drm"

2023-07-13 Thread Thomas Zimmermann
Hi some more thoughts below. Am 13.07.23 um 10:23 schrieb Uwe Kleine-König: Hello, after most feedback for my series "drm/crtc: Rename struct drm_crtc::dev to drm_dev"[1] was positive in principle, here comes a new series. I didn't call it v2 as it is different enough to stand on its own. The

Re: [PATCH 00/17] drm: rename various struct members "dev" -> "drm"

2023-07-13 Thread Maxime Ripard
On Thu, Jul 13, 2023 at 12:39:40PM +0200, Uwe Kleine-König wrote: > On Thu, Jul 13, 2023 at 12:23:50PM +0300, Jani Nikula wrote: > > On Thu, 13 Jul 2023, Uwe Kleine-König > > wrote: > > > after most feedback for my series "drm/crtc: Rename struct drm_crtc::dev > > > to drm_dev"[1] was positive in

Re: [PATCH 00/17] drm: rename various struct members "dev" -> "drm"

2023-07-13 Thread Jani Nikula
On Thu, 13 Jul 2023, Uwe Kleine-König wrote: > If you say you consider the idea bad or too costly to implement, that's > fine. But pointing to other areas that are bad shouldn't be a relevant > reason to shoot down this effort. I did not point to other places saying they're "bad". That's your opi

Re: [PATCH 00/17] drm: rename various struct members "dev" -> "drm"

2023-07-13 Thread Thomas Zimmermann
Hi Uwe Am 13.07.23 um 12:22 schrieb Uwe Kleine-König: [...] If that helps you: I plan to tackle these in a followup. I agree that's ugly, but fixing these in the same series is too much and if we agree that dev = crtc->dev; is ugly, there is then an intermediate state that either used

Re: [PATCH 00/17] drm: rename various struct members "dev" -> "drm"

2023-07-13 Thread Uwe Kleine-König
Hello Jani, On Thu, Jul 13, 2023 at 12:23:50PM +0300, Jani Nikula wrote: > On Thu, 13 Jul 2023, Uwe Kleine-König wrote: > > after most feedback for my series "drm/crtc: Rename struct drm_crtc::dev > > to drm_dev"[1] was positive in principle, here comes a new series. > > I find it obnoxious to s

Re: [PATCH 00/17] drm: rename various struct members "dev" -> "drm"

2023-07-13 Thread Uwe Kleine-König
Hello, On Thu, Jul 13, 2023 at 12:04:26PM +0200, Thomas Zimmermann wrote: > Am 13.07.23 um 10:23 schrieb Uwe Kleine-König: > > after most feedback for my series "drm/crtc: Rename struct drm_crtc::dev > > to drm_dev"[1] was positive in principle, here comes a new series. I > > didn't call it v2 as

Re: [PATCH 00/17] drm: rename various struct members "dev" -> "drm"

2023-07-13 Thread Thomas Zimmermann
Hi Am 13.07.23 um 10:23 schrieb Uwe Kleine-König: Hello, after most feedback for my series "drm/crtc: Rename struct drm_crtc::dev to drm_dev"[1] was positive in principle, here comes a new series. I didn't call it v2 as it is different enough to stand on its own. To me, it didn't seel as if t

Re: [PATCH 00/17] drm: rename various struct members "dev" -> "drm"

2023-07-13 Thread Jani Nikula
On Thu, 13 Jul 2023, Uwe Kleine-König wrote: > Hello, > > after most feedback for my series "drm/crtc: Rename struct drm_crtc::dev > to drm_dev"[1] was positive in principle, here comes a new series. I find it obnoxious to send a new series within 24 hours of the first, while the discussion is st

[PATCH 00/17] drm: rename various struct members "dev" -> "drm"

2023-07-13 Thread Uwe Kleine-König
Hello, after most feedback for my series "drm/crtc: Rename struct drm_crtc::dev to drm_dev"[1] was positive in principle, here comes a new series. I didn't call it v2 as it is different enough to stand on its own. The motivation is that "dev" (at least in my bubble) usually is a struct device *,