Re: [PATCH 0/5] drm/ssd130x: A few enhancements and cleanups

2023-06-07 Thread Javier Martinez Canillas
Thomas Zimmermann writes: Hello Thomas, > Hi Javierm, > > I've read through the patches and they look correct to me. > > Reviewed-by: Thomas Zimmermann > Thanks a lot for your review! > But I had one question about the page size. You round up to multiples of > page_size in several places. Th

Re: [PATCH 0/5] drm/ssd130x: A few enhancements and cleanups

2023-06-06 Thread Thomas Zimmermann
Hi Javierm, I've read through the patches and they look correct to me. Reviewed-by: Thomas Zimmermann But I had one question about the page size. You round up to multiples of page_size in several places. That could lead to an out-of-bounds access. Do you need to allocate GEM buffers to be mu

[PATCH 0/5] drm/ssd130x: A few enhancements and cleanups

2023-06-05 Thread Javier Martinez Canillas
Hello, While working on adding support for the SSD132X family of 4-bit grayscale Solomon OLED panel controllers, I noticed a few things in the driver that can be improved and make extending to support other chip families easier. I've split the preparatory patches in this series and will post the