Re: [PATCH 0/3] drm/panfrost: Expose HW counters to userspace

2019-05-14 Thread Steven Price
On 13/05/2019 14:39, Boris Brezillon wrote: > On Mon, 13 May 2019 13:48:08 +0100 > Steven Price wrote: > >> On 12/05/2019 14:38, Boris Brezillon wrote: >>> On Sat, 11 May 2019 15:32:20 -0700 >>> Alyssa Rosenzweig wrote: >>> Hi all, As Steven Price explained, the "GPU top" kbase

Re: [PATCH 0/3] drm/panfrost: Expose HW counters to userspace

2019-05-14 Thread Alyssa Rosenzweig
> This being said, I think I'll go for a simple debugfs-based iface to > unblock Alyssa. debugfs is not part of the stable-ABI and I guess we > can agree on explicitly marking it as "unstable" so that when we settle > on a generic interface to expose such counters we can get rid of the > old one.

Re: [PATCH 0/3] drm/panfrost: Expose HW counters to userspace

2019-05-14 Thread Steven Price
On 12/05/2019 14:38, Boris Brezillon wrote: > On Sat, 11 May 2019 15:32:20 -0700 > Alyssa Rosenzweig wrote: > >> Hi all, >> >> As Steven Price explained, the "GPU top" kbase approach is often more >> useful and accurate than per-draw timing. >> >> For a 3D game inside a GPU-accelerated desktop,

Re: [PATCH 0/3] drm/panfrost: Expose HW counters to userspace

2019-05-13 Thread Jordan Crouse
On Sun, May 12, 2019 at 03:40:26PM +0200, Boris Brezillon wrote: > On Tue, 30 Apr 2019 09:49:51 -0600 > Jordan Crouse wrote: > > > On Tue, Apr 30, 2019 at 06:10:53AM -0700, Rob Clark wrote: > > > On Tue, Apr 30, 2019 at 5:42 AM Boris Brezillon > > > wrote: > > > > > > > > +Rob, Eric, Mark and

Re: [PATCH 0/3] drm/panfrost: Expose HW counters to userspace

2019-05-13 Thread Boris Brezillon
On Mon, 13 May 2019 13:48:08 +0100 Steven Price wrote: > On 12/05/2019 14:38, Boris Brezillon wrote: > > On Sat, 11 May 2019 15:32:20 -0700 > > Alyssa Rosenzweig wrote: > > > >> Hi all, > >> > >> As Steven Price explained, the "GPU top" kbase approach is often more > >> useful and accurate th

Re: [PATCH 0/3] drm/panfrost: Expose HW counters to userspace

2019-05-13 Thread Alyssa Rosenzweig
Hi all, As Steven Price explained, the "GPU top" kbase approach is often more useful and accurate than per-draw timing. For a 3D game inside a GPU-accelerated desktop, the games' counters *should* include desktop overhead. This external overhead does affect the game's performance, especially if

Re: [PATCH 0/3] drm/panfrost: Expose HW counters to userspace

2019-05-12 Thread Boris Brezillon
On Tue, 30 Apr 2019 09:49:51 -0600 Jordan Crouse wrote: > On Tue, Apr 30, 2019 at 06:10:53AM -0700, Rob Clark wrote: > > On Tue, Apr 30, 2019 at 5:42 AM Boris Brezillon > > wrote: > > > > > > +Rob, Eric, Mark and more > > > > > > Hi, > > > > > > On Fri, 5 Apr 2019 16:20:45 +0100 > > > Steven P

Re: [PATCH 0/3] drm/panfrost: Expose HW counters to userspace

2019-05-12 Thread Boris Brezillon
On Sat, 11 May 2019 15:32:20 -0700 Alyssa Rosenzweig wrote: > Hi all, > > As Steven Price explained, the "GPU top" kbase approach is often more > useful and accurate than per-draw timing. > > For a 3D game inside a GPU-accelerated desktop, the games' counters > *should* include desktop overhea

Re: [PATCH 0/3] drm/panfrost: Expose HW counters to userspace

2019-05-12 Thread Boris Brezillon
On Wed, 01 May 2019 10:12:42 -0700 Eric Anholt wrote: > Boris Brezillon writes: > > > +Rob, Eric, Mark and more > > > > Hi, > > > > On Fri, 5 Apr 2019 16:20:45 +0100 > > Steven Price wrote: > > > >> On 04/04/2019 16:20, Boris Brezillon wrote: > >> > Hello, > >> > > >> > This patch adds ne

Re: [PATCH 0/3] drm/panfrost: Expose HW counters to userspace

2019-05-01 Thread Eric Anholt
Boris Brezillon writes: > +Rob, Eric, Mark and more > > Hi, > > On Fri, 5 Apr 2019 16:20:45 +0100 > Steven Price wrote: > >> On 04/04/2019 16:20, Boris Brezillon wrote: >> > Hello, >> > >> > This patch adds new ioctls to expose GPU counters to userspace. >> > These will be used by the mesa driv

Re: [PATCH 0/3] drm/panfrost: Expose HW counters to userspace

2019-04-30 Thread Jordan Crouse
On Tue, Apr 30, 2019 at 06:10:53AM -0700, Rob Clark wrote: > On Tue, Apr 30, 2019 at 5:42 AM Boris Brezillon > wrote: > > > > +Rob, Eric, Mark and more > > > > Hi, > > > > On Fri, 5 Apr 2019 16:20:45 +0100 > > Steven Price wrote: > > > > > On 04/04/2019 16:20, Boris Brezillon wrote: > > > > Hello

Re: [PATCH 0/3] drm/panfrost: Expose HW counters to userspace

2019-04-30 Thread Rob Clark
On Tue, Apr 30, 2019 at 5:42 AM Boris Brezillon wrote: > > +Rob, Eric, Mark and more > > Hi, > > On Fri, 5 Apr 2019 16:20:45 +0100 > Steven Price wrote: > > > On 04/04/2019 16:20, Boris Brezillon wrote: > > > Hello, > > > > > > This patch adds new ioctls to expose GPU counters to userspace. > > >

Re: [PATCH 0/3] drm/panfrost: Expose HW counters to userspace

2019-04-30 Thread Boris Brezillon
+Rob, Eric, Mark and more Hi, On Fri, 5 Apr 2019 16:20:45 +0100 Steven Price wrote: > On 04/04/2019 16:20, Boris Brezillon wrote: > > Hello, > > > > This patch adds new ioctls to expose GPU counters to userspace. > > These will be used by the mesa driver (should be posted soon). > > > > A few

Re: [PATCH 0/3] drm/panfrost: Expose HW counters to userspace

2019-04-08 Thread Steven Price
On 04/04/2019 16:20, Boris Brezillon wrote: > Hello, > > This patch adds new ioctls to expose GPU counters to userspace. > These will be used by the mesa driver (should be posted soon). > > A few words about the implementation: I followed the VC4/Etnaviv model > where perf counters are retrieved

Re: [PATCH 0/3] drm/panfrost: Expose HW counters to userspace

2019-04-08 Thread Alyssa Rosenzweig
+1 ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 0/3] drm/panfrost: Expose HW counters to userspace

2019-04-08 Thread Alyssa Rosenzweig
> Since one of the primary use cases is to draw pretty graphs of the > system load [1], this "per-job" information isn't all that relevant (and > minimal performance overhead is important). And if you want to monitor > just one application it is usually easiest to ensure that it is the only > thing

Re: [PATCH 0/3] drm/panfrost: Expose HW counters to userspace

2019-04-05 Thread Boris Brezillon
On Fri, 5 Apr 2019 09:33:55 -0700 Alyssa Rosenzweig wrote: > > Since one of the primary use cases is to draw pretty graphs of the > > system load [1], this "per-job" information isn't all that relevant (and > > minimal performance overhead is important). And if you want to monitor > > just one ap

[PATCH 0/3] drm/panfrost: Expose HW counters to userspace

2019-04-04 Thread Boris Brezillon
Hello, This patch adds new ioctls to expose GPU counters to userspace. These will be used by the mesa driver (should be posted soon). A few words about the implementation: I followed the VC4/Etnaviv model where perf counters are retrieved on a per-job basis. This allows one to have get accurate r