Re: [PATCH 0/3] Provide struct ttm_global for TTM global state

2018-10-19 Thread Koenig, Christian
Am 19.10.18 um 09:44 schrieb Thomas Zimmermann: > Hi > > Am 19.10.18 um 09:24 schrieb Koenig, Christian: >> Hi Thomas, >> >> I honestly still find that way to complicated compared to what it >> actually does. >> >> Both ttm_mem_global and ttm_bo_global can just be some static variables. >> E.g. the

Re: [PATCH 0/3] Provide struct ttm_global for TTM global state

2018-10-19 Thread Thomas Zimmermann
Hi Am 19.10.18 um 09:24 schrieb Koenig, Christian: > Hi Thomas, > > I honestly still find that way to complicated compared to what it > actually does. > > Both ttm_mem_global and ttm_bo_global can just be some static variables. > E.g. the whole handling with drm_global_reference is just superf

Re: [PATCH 0/3] Provide struct ttm_global for TTM global state

2018-10-19 Thread Koenig, Christian
Hi Thomas, I honestly still find that way to complicated compared to what it actually does. Both ttm_mem_global and ttm_bo_global can just be some static variables. E.g. the whole handling with drm_global_reference is just superfluous. Can I just write a patch to clean up the mess we created?

[PATCH 0/3] Provide struct ttm_global for TTM global state

2018-10-18 Thread Thomas Zimmermann
TTM provides global memory and a global BO that is shared by all TTM-based drivers. The data structures are provided by struct drm_global and its helpers. All TTM-based DRM drivers copy the initialization and clean-up code for the global TTM state from each other; leading to code duplication. The