Re: [PATCH 0/2] drm: revert some framebuffer API tests

2024-10-03 Thread Maxime Ripard
On Wed, Oct 02, 2024 at 03:10:14PM GMT, Jani Nikula wrote: > On Wed, 25 Sep 2024, Maxime Ripard wrote: > > On Wed, Sep 25, 2024 at 01:52:02PM GMT, Simona Vetter wrote: > >> I think for at least drm the consensus is clear, we won't have kunit tests > >> that splat. > > > > Where was that ever discu

Re: [PATCH 0/2] drm: revert some framebuffer API tests

2024-10-02 Thread Jani Nikula
On Wed, 25 Sep 2024, Maxime Ripard wrote: > On Wed, Sep 25, 2024 at 01:52:02PM GMT, Simona Vetter wrote: >> I think for at least drm the consensus is clear, we won't have kunit tests >> that splat. > > Where was that ever discussed? Well, where was it ever agreed that it's okay for drm kunit test

Re: [PATCH 0/2] drm: revert some framebuffer API tests

2024-09-26 Thread Maxime Ripard
On Wed, Sep 25, 2024 at 09:04:39AM GMT, Guenter Roeck wrote: > On 9/25/24 06:05, Maxime Ripard wrote: > [ ... ] > > > > We've had similar discussions in the past around unit tests that wasted > > > too much cpu time with randomized combinatorial testing, and we've thrown > > > those out too from d

Re: [PATCH 0/2] drm: revert some framebuffer API tests

2024-09-25 Thread Guenter Roeck
On 9/25/24 06:05, Maxime Ripard wrote: [ ... ] We've had similar discussions in the past around unit tests that wasted too much cpu time with randomized combinatorial testing, and we've thrown those out too from drm. Test hygiene matters. We had that discussion because those tests could run fo

Re: [PATCH 0/2] drm: revert some framebuffer API tests

2024-09-25 Thread Guenter Roeck
On 9/25/24 05:59, Maxime Ripard wrote: ... All I'm saying it generates an extra burden for current real world CI systems that run tests on a massive scale and even have paid maintainers. It's not trivial to sort out expected and unexpected warnings, and keep the filters updated every time the wa

Re: [PATCH 0/2] drm: revert some framebuffer API tests

2024-09-25 Thread Maxime Ripard
On Wed, Sep 25, 2024 at 01:52:02PM GMT, Simona Vetter wrote: > On Tue, Sep 24, 2024 at 08:09:38AM -0700, Guenter Roeck wrote: > > On 9/24/24 06:56, Maxime Ripard wrote: > > > On Tue, Sep 24, 2024 at 06:37:59AM GMT, Guenter Roeck wrote: > > > > On 9/24/24 04:54, Maxime Ripard wrote: > > > > > +Guent

Re: [PATCH 0/2] drm: revert some framebuffer API tests

2024-09-25 Thread Maxime Ripard
On Wed, Sep 25, 2024 at 12:41:40PM GMT, Jani Nikula wrote: > On Tue, 24 Sep 2024, Maxime Ripard wrote: > > On Tue, Sep 24, 2024 at 06:56:26PM GMT, Jani Nikula wrote: > >> On Tue, 24 Sep 2024, Guenter Roeck wrote: > >> On Tue, Sep 24, 2024 at 12:06:28PM GMT, Simona Vetter wrote: > >> > Ye

Re: [PATCH 0/2] drm: revert some framebuffer API tests

2024-09-25 Thread Simona Vetter
On Tue, Sep 24, 2024 at 08:09:38AM -0700, Guenter Roeck wrote: > On 9/24/24 06:56, Maxime Ripard wrote: > > On Tue, Sep 24, 2024 at 06:37:59AM GMT, Guenter Roeck wrote: > > > On 9/24/24 04:54, Maxime Ripard wrote: > > > > +Guenter > > > > > > > > On Tue, Sep 24, 2024 at 12:06:28PM GMT, Simona Vett

Re: [PATCH 0/2] drm: revert some framebuffer API tests

2024-09-25 Thread Jani Nikula
On Tue, 24 Sep 2024, Maxime Ripard wrote: > On Tue, Sep 24, 2024 at 06:56:26PM GMT, Jani Nikula wrote: >> On Tue, 24 Sep 2024, Guenter Roeck wrote: >> On Tue, Sep 24, 2024 at 12:06:28PM GMT, Simona Vetter wrote: >> > Yeah I think long-term we might want a kunit framework so that we can >

Re: [PATCH 0/2] drm: revert some framebuffer API tests

2024-09-24 Thread Guenter Roeck
On 9/24/24 09:57, Maxime Ripard wrote: On Tue, Sep 24, 2024 at 06:56:26PM GMT, Jani Nikula wrote: On Tue, 24 Sep 2024, Guenter Roeck wrote: On Tue, Sep 24, 2024 at 12:06:28PM GMT, Simona Vetter wrote: Yeah I think long-term we might want a kunit framework so that we can catch dmesg warnings w

Re: [PATCH 0/2] drm: revert some framebuffer API tests

2024-09-24 Thread Maxime Ripard
On Tue, Sep 24, 2024 at 06:56:26PM GMT, Jani Nikula wrote: > On Tue, 24 Sep 2024, Guenter Roeck wrote: > On Tue, Sep 24, 2024 at 12:06:28PM GMT, Simona Vetter wrote: > > Yeah I think long-term we might want a kunit framework so that we can > > catch dmesg warnings we expect and test f

Re: [PATCH 0/2] drm: revert some framebuffer API tests

2024-09-24 Thread Guenter Roeck
On 9/24/24 08:56, Jani Nikula wrote: On Tue, 24 Sep 2024, Guenter Roeck wrote: On Tue, Sep 24, 2024 at 12:06:28PM GMT, Simona Vetter wrote: Yeah I think long-term we might want a kunit framework so that we can catch dmesg warnings we expect and test for those, without those warnings actually g

Re: [PATCH 0/2] drm: revert some framebuffer API tests

2024-09-24 Thread Jani Nikula
On Tue, 24 Sep 2024, Guenter Roeck wrote: On Tue, Sep 24, 2024 at 12:06:28PM GMT, Simona Vetter wrote: > Yeah I think long-term we might want a kunit framework so that we can > catch dmesg warnings we expect and test for those, without those warnings > actually going to dmesg. Sim

Re: [PATCH 0/2] drm: revert some framebuffer API tests

2024-09-24 Thread Guenter Roeck
On 9/24/24 06:56, Maxime Ripard wrote: On Tue, Sep 24, 2024 at 06:37:59AM GMT, Guenter Roeck wrote: On 9/24/24 04:54, Maxime Ripard wrote: +Guenter On Tue, Sep 24, 2024 at 12:06:28PM GMT, Simona Vetter wrote: On Tue, Sep 17, 2024 at 08:43:50PM +0300, Jani Nikula wrote: The tests consistently

Re: [PATCH 0/2] drm: revert some framebuffer API tests

2024-09-24 Thread Maxime Ripard
On Tue, Sep 24, 2024 at 06:37:59AM GMT, Guenter Roeck wrote: > On 9/24/24 04:54, Maxime Ripard wrote: > > +Guenter > > > > On Tue, Sep 24, 2024 at 12:06:28PM GMT, Simona Vetter wrote: > > > On Tue, Sep 17, 2024 at 08:43:50PM +0300, Jani Nikula wrote: > > > > The tests consistently trigger WARNs in

Re: [PATCH 0/2] drm: revert some framebuffer API tests

2024-09-24 Thread Guenter Roeck
On 9/24/24 04:54, Maxime Ripard wrote: +Guenter On Tue, Sep 24, 2024 at 12:06:28PM GMT, Simona Vetter wrote: On Tue, Sep 17, 2024 at 08:43:50PM +0300, Jani Nikula wrote: The tests consistently trigger WARNs in drm_framebuffer code. I'm not sure what the point is with type of belts and suspende

Re: [PATCH 0/2] drm: revert some framebuffer API tests

2024-09-24 Thread Maxime Ripard
+Guenter On Tue, Sep 24, 2024 at 12:06:28PM GMT, Simona Vetter wrote: > On Tue, Sep 17, 2024 at 08:43:50PM +0300, Jani Nikula wrote: > > The tests consistently trigger WARNs in drm_framebuffer code. I'm not > > sure what the point is with type of belts and suspenders tests. The > > warnings *are*

Re: [PATCH 0/2] drm: revert some framebuffer API tests

2024-09-24 Thread Simona Vetter
On Tue, Sep 17, 2024 at 08:43:50PM +0300, Jani Nikula wrote: > The tests consistently trigger WARNs in drm_framebuffer code. I'm not > sure what the point is with type of belts and suspenders tests. The > warnings *are* the way to flag erroneous API usage. > > Warnings in turn trigger failures in

[PATCH 0/2] drm: revert some framebuffer API tests

2024-09-17 Thread Jani Nikula
The tests consistently trigger WARNs in drm_framebuffer code. I'm not sure what the point is with type of belts and suspenders tests. The warnings *are* the way to flag erroneous API usage. Warnings in turn trigger failures in CI. Filtering the warnings are error prone, and, crucially, would also