Re: [PATCH -fixes 5/5] drm/vmwgfx: Fix a buffer object eviction regression

2018-09-14 Thread Matthew Wilcox
On Thu, Sep 13, 2018 at 04:56:53PM +0200, Thomas Hellstrom wrote: > Hi, > > On 09/13/2018 04:10 PM, Matthew Wilcox wrote: > > On Thu, Sep 13, 2018 at 01:58:37PM +0200, Thomas Hellstrom wrote: > > > Commit 4eb085e42fde ("drm/vmwgfx: Convert to new IDA API") indroduced > > > an incorrect return valu

Re: [PATCH -fixes 5/5] drm/vmwgfx: Fix a buffer object eviction regression

2018-09-14 Thread Matthew Wilcox
On Thu, Sep 13, 2018 at 01:58:37PM +0200, Thomas Hellstrom wrote: > Commit 4eb085e42fde ("drm/vmwgfx: Convert to new IDA API") indroduced > an incorrect return value from the function vmw_gmrid_man_get_node(), > when we run out if integer ids. Instead of returning 0 (meaning > non-fatal error) we f

Re: [PATCH -fixes 5/5] drm/vmwgfx: Fix a buffer object eviction regression

2018-09-14 Thread Matthew Wilcox
On Thu, Sep 13, 2018 at 06:52:43PM +0200, Thomas Hellstrom wrote: > On 09/13/2018 05:28 PM, Matthew Wilcox wrote: > > On Thu, Sep 13, 2018 at 04:56:53PM +0200, Thomas Hellstrom wrote: > > > On 09/13/2018 04:10 PM, Matthew Wilcox wrote: > > > > I think this could be better though ... if ida_alloc()

Re: [PATCH -fixes 5/5] drm/vmwgfx: Fix a buffer object eviction regression

2018-09-13 Thread Thomas Hellstrom
On 09/13/2018 07:38 PM, Matthew Wilcox wrote: On Thu, Sep 13, 2018 at 06:52:43PM +0200, Thomas Hellstrom wrote: On 09/13/2018 05:28 PM, Matthew Wilcox wrote: On Thu, Sep 13, 2018 at 04:56:53PM +0200, Thomas Hellstrom wrote: On 09/13/2018 04:10 PM, Matthew Wilcox wrote: I think this could be b

Re: [PATCH -fixes 5/5] drm/vmwgfx: Fix a buffer object eviction regression

2018-09-13 Thread Thomas Hellstrom
On 09/13/2018 05:28 PM, Matthew Wilcox wrote: On Thu, Sep 13, 2018 at 04:56:53PM +0200, Thomas Hellstrom wrote: Hi, On 09/13/2018 04:10 PM, Matthew Wilcox wrote: On Thu, Sep 13, 2018 at 01:58:37PM +0200, Thomas Hellstrom wrote: Commit 4eb085e42fde ("drm/vmwgfx: Convert to new IDA API") indrod

Re: [PATCH -fixes 5/5] drm/vmwgfx: Fix a buffer object eviction regression

2018-09-13 Thread Thomas Hellstrom
Hi, On 09/13/2018 04:10 PM, Matthew Wilcox wrote: On Thu, Sep 13, 2018 at 01:58:37PM +0200, Thomas Hellstrom wrote: Commit 4eb085e42fde ("drm/vmwgfx: Convert to new IDA API") indroduced an incorrect return value from the function vmw_gmrid_man_get_node(), when we run out if integer ids. Instead

[PATCH -fixes 5/5] drm/vmwgfx: Fix a buffer object eviction regression

2018-09-13 Thread Thomas Hellstrom
Commit 4eb085e42fde ("drm/vmwgfx: Convert to new IDA API") indroduced an incorrect return value from the function vmw_gmrid_man_get_node(), when we run out if integer ids. Instead of returning 0 (meaning non-fatal error) we forward the ida_simple_get error code -ENOSPC. This causes TTM not to retry