[PATCH] vmwgfx: add missing mutex_unlocks

2012-08-06 Thread Devendra Naga
Hi Thomas, On Mon, Aug 6, 2012 at 1:52 PM, Thomas Hellstrom wrote: > NAK, > > The mutex unlock is done in vmw_fifo_commit. The mutex is protecting the > fifo memory against multiple simultaneous reservers. > Thanks for the answer :-). sorry for your time... i will definitely try more reading an

[PATCH] vmwgfx: add missing mutex_unlocks

2012-08-06 Thread Thomas Hellstrom
NAK, The mutex unlock is done in vmw_fifo_commit. The mutex is protecting the fifo memory against multiple simultaneous reservers. /Thomas On 08/04/2012 07:33 AM, Devendra Naga wrote: > we have done a proper mutex_unlock in the error cases of the > vmw_fifo_reserve, but > there are missing m

Re: [PATCH] vmwgfx: add missing mutex_unlocks

2012-08-06 Thread Devendra Naga
Hi Thomas, On Mon, Aug 6, 2012 at 1:52 PM, Thomas Hellstrom wrote: > NAK, > > The mutex unlock is done in vmw_fifo_commit. The mutex is protecting the > fifo memory against multiple simultaneous reservers. > Thanks for the answer :-). sorry for your time... i will definitely try more reading and

Re: [PATCH] vmwgfx: add missing mutex_unlocks

2012-08-06 Thread Thomas Hellstrom
NAK, The mutex unlock is done in vmw_fifo_commit. The mutex is protecting the fifo memory against multiple simultaneous reservers. /Thomas On 08/04/2012 07:33 AM, Devendra Naga wrote: we have done a proper mutex_unlock in the error cases of the vmw_fifo_reserve, but there are missing mute

[PATCH] vmwgfx: add missing mutex_unlocks

2012-08-05 Thread Devendra Naga
we have done a proper mutex_unlock in the error cases of the vmw_fifo_reserve, but there are missing mutex unlocks where we return a valid pointer in vmw_fifo_reserve. Signed-off-by: Devendra Naga --- drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c |7 +-- 1 file changed, 5 insertions(+), 2 delet

[PATCH] vmwgfx: add missing mutex_unlocks

2012-08-04 Thread Devendra Naga
we have done a proper mutex_unlock in the error cases of the vmw_fifo_reserve, but there are missing mutex unlocks where we return a valid pointer in vmw_fifo_reserve. Signed-off-by: Devendra Naga --- drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c |7 +-- 1 file changed, 5 insertions(+), 2 delet