Re: [PATCH] video: fbdev: pvr2fb: initialize variables

2020-08-03 Thread Sam Ravnborg
Hi Tom, On Mon, Jul 20, 2020 at 12:18:45PM -0700, t...@redhat.com wrote: > From: Tom Rix > > clang static analysis reports this repesentative error > > pvr2fb.c:1049:2: warning: 1st function call argument > is an uninitialized value [core.CallAndMessage] > if (*cable_arg) > ^~

Re: [PATCH] video: fbdev: pvr2fb: initialize variables

2020-07-20 Thread Arnd Bergmann
On Mon, Jul 20, 2020 at 9:19 PM wrote: > > From: Tom Rix > > clang static analysis reports this repesentative error > > pvr2fb.c:1049:2: warning: 1st function call argument > is an uninitialized value [core.CallAndMessage] > if (*cable_arg) > ^~~ > > Problem is that

[PATCH] video: fbdev: pvr2fb: initialize variables

2020-07-20 Thread trix
From: Tom Rix clang static analysis reports this repesentative error pvr2fb.c:1049:2: warning: 1st function call argument is an uninitialized value [core.CallAndMessage] if (*cable_arg) ^~~ Problem is that cable_arg depends on the input loop to set the cable_arg[0]