Re: [PATCH] video: fbdev: mmp: Fix deferred clk handling in mmphw_probe()

2023-04-22 Thread Helge Deller
On 4/13/23 21:33, Christophe JAILLET wrote: When dev_err_probe() is called, 'ret' holds the value of the previous successful devm_request_irq() call. 'ret' should be assigned with a meaningful value before being used in dev_err_probe(). While at it, use and return "PTR_ERR(ctrl->clk)" instead of

Re: [PATCH] video: fbdev: mmp: Fix deferred clk handling in mmphw_probe()

2023-04-18 Thread Christophe JAILLET
Le 19/04/2023 à 06:59, Dan Carpenter a écrit : On Sat, Apr 15, 2023 at 04:09:03PM +0300, Dan Carpenter wrote: On Thu, Apr 13, 2023 at 09:33:17PM +0200, Christophe JAILLET wrote: When dev_err_probe() is called, 'ret' holds the value of the previous successful devm_request_irq() call. 'ret' shoul

Re: [PATCH] video: fbdev: mmp: Fix deferred clk handling in mmphw_probe()

2023-04-18 Thread Dan Carpenter
On Sat, Apr 15, 2023 at 04:09:03PM +0300, Dan Carpenter wrote: > On Thu, Apr 13, 2023 at 09:33:17PM +0200, Christophe JAILLET wrote: > > When dev_err_probe() is called, 'ret' holds the value of the previous > > successful devm_request_irq() call. > > 'ret' should be assigned with a meaningful value

Re: [PATCH] video: fbdev: mmp: Fix deferred clk handling in mmphw_probe()

2023-04-15 Thread Dan Carpenter
On Thu, Apr 13, 2023 at 09:33:17PM +0200, Christophe JAILLET wrote: > When dev_err_probe() is called, 'ret' holds the value of the previous > successful devm_request_irq() call. > 'ret' should be assigned with a meaningful value before being used in > dev_err_probe(). > > While at it, use and retu

[PATCH] video: fbdev: mmp: Fix deferred clk handling in mmphw_probe()

2023-04-13 Thread Christophe JAILLET
When dev_err_probe() is called, 'ret' holds the value of the previous successful devm_request_irq() call. 'ret' should be assigned with a meaningful value before being used in dev_err_probe(). While at it, use and return "PTR_ERR(ctrl->clk)" instead of a hard-coded "-ENOENT" so that -EPROBE_DEFER