Re: [PATCH] video: fbdev: arkfb: fix possible object reference leak

2023-10-10 Thread Daniel Vetter
On Fri, Oct 06, 2023 at 04:34:01PM +0200, Ondrej Zary wrote: > On Friday 06 October 2023, Helge Deller wrote: > > On 10/5/23 09:01, Zhang Shurong wrote: > > > Add missing pci_disable_device() in error path in ark_pci_probe(). > > > > Do you have this hardware and tested your patch? > > I'm sure th

Re: [PATCH] video: fbdev: arkfb: fix possible object reference leak

2023-10-06 Thread Ondrej Zary
On Friday 06 October 2023, Helge Deller wrote: > On 10/5/23 09:01, Zhang Shurong wrote: > > Add missing pci_disable_device() in error path in ark_pci_probe(). > > Do you have this hardware and tested your patch? > I'm sure there is a reason, why "pci_disable_device()" was commented > out in the or

Re: [PATCH] video: fbdev: arkfb: fix possible object reference leak

2023-10-06 Thread Zhang Shurong
Since the graphic card in question is quite old, I haven't had the opportunity to personally test it yet. I decided to send the patch because, upon careful consideration, I couldn't find any compelling reasons not to include the call to pci_disable_device(). However, I completely understand your

Re: [PATCH] video: fbdev: arkfb: fix possible object reference leak

2023-10-06 Thread Helge Deller
On 10/5/23 09:01, Zhang Shurong wrote: Add missing pci_disable_device() in error path in ark_pci_probe(). Do you have this hardware and tested your patch? I'm sure there is a reason, why "pci_disable_device()" was commented out in the original submission in commit 681e14730c73c... Additionally

[PATCH] video: fbdev: arkfb: fix possible object reference leak

2023-10-05 Thread Zhang Shurong
Add missing pci_disable_device() in error path in ark_pci_probe(). Signed-off-by: Zhang Shurong --- drivers/video/fbdev/arkfb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/arkfb.c b/drivers/video/fbdev/arkfb.c index 60a96fdb5dd8..6c4e5065646f 10064