Re: [PATCH] video: fbdev: Convert timers to use timer_setup()

2017-11-10 Thread Bartlomiej Zolnierkiewicz
On Thursday, November 09, 2017 10:40:13 AM Kees Cook wrote: > On Thu, Nov 9, 2017 at 9:08 AM, Bartlomiej Zolnierkiewicz [...] > > [ Please compile these timer changes with PXA3XX_GCU_DEBUG and > > PXA3XX_GCU_DEBUG_TIMER defined. ] > > Hm, these appear to be manual knobs? What do you think abou

Re: [PATCH] video: fbdev: Convert timers to use timer_setup()

2017-11-10 Thread Kees Cook
On Thu, Nov 9, 2017 at 9:08 AM, Bartlomiej Zolnierkiewicz wrote: > On Tuesday, October 24, 2017 08:20:26 AM Kees Cook wrote: > >> diff --git a/drivers/video/fbdev/pxa3xx-gcu.c >> b/drivers/video/fbdev/pxa3xx-gcu.c >> index 933619da1a94..e88447eac32c 100644 >> --- a/drivers/video/fbdev/pxa3xx-gcu.

Re: [PATCH] video: fbdev: Convert timers to use timer_setup()

2017-11-09 Thread Bartlomiej Zolnierkiewicz
On Tuesday, October 24, 2017 08:20:26 AM Kees Cook wrote: > diff --git a/drivers/video/fbdev/pxa3xx-gcu.c > b/drivers/video/fbdev/pxa3xx-gcu.c > index 933619da1a94..e88447eac32c 100644 > --- a/drivers/video/fbdev/pxa3xx-gcu.c > +++ b/drivers/video/fbdev/pxa3xx-gcu.c > @@ -513,16 +513,10 @@ pxa3xx

[PATCH] video: fbdev: Convert timers to use timer_setup()

2017-10-25 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. One tracking pointer was added, and one initialization was cleaned up. Cc: Bartlomiej Zolnierkiewicz Cc: Be