Re: [PATCH] soc: mediatek: cmdq: Remove cmdq_pkt_flush()

2021-01-31 Thread Matthias Brugger
On 30/01/2021 10:45, Chun-Kuang Hu wrote: > Hi, Matthias: > > Chun-Kuang Hu 於 2021年1月10日 週日 上午6:59寫道: >> >> Hi, Matthias: >> >> Chun-Kuang Hu 於 2020年12月3日 週四 上午7:59寫道: >>> >>> rx_callback is a standard mailbox callback mechanism and could >>> cover the function of proprietary cmdq_task_cb, so

Re: [PATCH] soc: mediatek: cmdq: Remove cmdq_pkt_flush()

2021-01-30 Thread Chun-Kuang Hu
Hi, Matthias: Chun-Kuang Hu 於 2021年1月10日 週日 上午6:59寫道: > > Hi, Matthias: > > Chun-Kuang Hu 於 2020年12月3日 週四 上午7:59寫道: > > > > rx_callback is a standard mailbox callback mechanism and could > > cover the function of proprietary cmdq_task_cb, so it is better > > to use the standard one instead of th

Re: [PATCH] soc: mediatek: cmdq: Remove cmdq_pkt_flush()

2021-01-09 Thread Chun-Kuang Hu
Hi, Matthias: Chun-Kuang Hu 於 2020年12月3日 週四 上午7:59寫道: > > rx_callback is a standard mailbox callback mechanism and could > cover the function of proprietary cmdq_task_cb, so it is better > to use the standard one instead of the proprietary one. But > register rx_callback should before mbox_reques

[PATCH] soc: mediatek: cmdq: Remove cmdq_pkt_flush()

2020-12-02 Thread Chun-Kuang Hu
rx_callback is a standard mailbox callback mechanism and could cover the function of proprietary cmdq_task_cb, so it is better to use the standard one instead of the proprietary one. But register rx_callback should before mbox_request_channel(), so remove cmdq_pkt_flush() and let client driver impl