[PATCH] radeon: Do not directly dereference pointers to BIOS area.

2015-03-20 Thread Deucher, Alexander
> -Original Message- > From: David Miller [mailto:davem at davemloft.net] > Sent: Friday, March 20, 2015 1:24 PM > To: Koenig, Christian > Cc: Deucher, Alexander; dri-devel at lists.freedesktop.org; linux- > kernel at vger.kernel.org > Subject: Re: [PATCH] ra

[PATCH] radeon: Do not directly dereference pointers to BIOS area.

2015-03-20 Thread David Miller
From: Christian König Date: Fri, 20 Mar 2015 10:38:32 +0100 > On 19.03.2015 17:29, David Miller wrote: >> From: Christian König >> Date: Thu, 19 Mar 2015 09:50:58 +0100 >> >>> In general I would say yes, but for this particular hardware it's a >>> bit questionable to do so. >>> >>> For radeon

[PATCH] radeon: Do not directly dereference pointers to BIOS area.

2015-03-20 Thread Christian König
On 19.03.2015 17:29, David Miller wrote: > From: Christian König > Date: Thu, 19 Mar 2015 09:50:58 +0100 > >> In general I would say yes, but for this particular hardware it's a >> bit questionable to do so. >> >> For radeon hardware to work correctly the CPU access to the PCIE BARs >> should wor

[PATCH] radeon: Do not directly dereference pointers to BIOS area.

2015-03-20 Thread Alex Deucher
On Fri, Mar 20, 2015 at 5:38 AM, Christian König wrote: > On 19.03.2015 17:29, David Miller wrote: >> >> From: Christian König >> Date: Thu, 19 Mar 2015 09:50:58 +0100 >> >>> In general I would say yes, but for this particular hardware it's a >>> bit questionable to do so. >>> >>> For radeon ha

[PATCH] radeon: Do not directly dereference pointers to BIOS area.

2015-03-19 Thread David Miller
From: Christian König Date: Thu, 19 Mar 2015 09:50:58 +0100 > In general I would say yes, but for this particular hardware it's a > bit questionable to do so. > > For radeon hardware to work correctly the CPU access to the PCIE BARs > should work even without using the specialized IO macros/fun

[PATCH] radeon: Do not directly dereference pointers to BIOS area.

2015-03-19 Thread Christian König
In general I would say yes, but for this particular hardware it's a bit questionable to do so. For radeon hardware to work correctly the CPU access to the PCIE BARs should work even without using the specialized IO macros/functions, otherwise mapping VRAM CPU accessible isn't really possible.

[PATCH] radeon: Do not directly dereference pointers to BIOS area.

2015-03-18 Thread David Miller
Use readb() and memcpy_fromio() accessors instead. Signed-off-by: David S. Miller diff --git a/drivers/gpu/drm/radeon/radeon_bios.c b/drivers/gpu/drm/radeon/radeon_bios.c index 63ccb8f..d27e4cc 100644 --- a/drivers/gpu/drm/radeon/radeon_bios.c +++ b/drivers/gpu/drm/radeon/radeon_bios.c @@ -76,