[PATCH] r600g: remove useless call to u_upload_flush

2011-06-13 Thread Alex Deucher
On Fri, Jun 10, 2011 at 7:09 PM, Alex Deucher wrote: > On Fri, Jun 10, 2011 at 7:08 PM, Alex Deucher > wrote: >> On Fri, Jun 10, 2011 at 2:10 PM, Rafael Monica wrote: >>> I cannot test it now, but last time the flush call was removed it >>> caused a major regression on Evergreen. See: >>> >>> h

Re: [PATCH] r600g: remove useless call to u_upload_flush

2011-06-13 Thread Alex Deucher
On Fri, Jun 10, 2011 at 7:09 PM, Alex Deucher wrote: > On Fri, Jun 10, 2011 at 7:08 PM, Alex Deucher wrote: >> On Fri, Jun 10, 2011 at 2:10 PM, Rafael Monica wrote: >>> I cannot test it now, but last time the flush call was removed it >>> caused a major regression on Evergreen. See: >>> >>> http

[PATCH] r600g: remove useless call to u_upload_flush

2011-06-10 Thread Rafael Monica
I cannot test it now, but last time the flush call was removed it caused a major regression on Evergreen. See: https://bugs.freedesktop.org/show_bug.cgi?id=34008 So please do not remove unless there are also no regressions on Evergreen. Thanks.

[PATCH] r600g: remove useless call to u_upload_flush

2011-06-10 Thread Alex Deucher
On Fri, Jun 10, 2011 at 7:08 PM, Alex Deucher wrote: > On Fri, Jun 10, 2011 at 2:10 PM, Rafael Monica wrote: >> I cannot test it now, but last time the flush call was removed it >> caused a major regression on Evergreen. See: >> >> https://bugs.freedesktop.org/show_bug.cgi?id=34008 >> >> So pleas

[PATCH] r600g: remove useless call to u_upload_flush

2011-06-10 Thread Alex Deucher
On Fri, Jun 10, 2011 at 2:10 PM, Rafael Monica wrote: > I cannot test it now, but last time the flush call was removed it > caused a major regression on Evergreen. See: > > https://bugs.freedesktop.org/show_bug.cgi?id=34008 > > So please do not remove unless there are also no regressions on Evergr

Re: [PATCH] r600g: remove useless call to u_upload_flush

2011-06-10 Thread Alex Deucher
On Fri, Jun 10, 2011 at 7:08 PM, Alex Deucher wrote: > On Fri, Jun 10, 2011 at 2:10 PM, Rafael Monica wrote: >> I cannot test it now, but last time the flush call was removed it >> caused a major regression on Evergreen. See: >> >> https://bugs.freedesktop.org/show_bug.cgi?id=34008 >> >> So pleas

Re: [PATCH] r600g: remove useless call to u_upload_flush

2011-06-10 Thread Alex Deucher
On Fri, Jun 10, 2011 at 2:10 PM, Rafael Monica wrote: > I cannot test it now, but last time the flush call was removed it > caused a major regression on Evergreen. See: > > https://bugs.freedesktop.org/show_bug.cgi?id=34008 > > So please do not remove unless there are also no regressions on Evergr

[PATCH] r600g: remove useless call to u_upload_flush

2011-06-10 Thread Pierre-Eric Pelloux-Prayer
u_upload_flush() is called each time r600_flush() is used. There is a comment specifically saying : /* XXX This shouldn't be really necessary, but removing it breaks some tests. * Needless buffer reallocations may significantly increase memory consumption, * so getting

re: [PATCH] r600g: remove useless call to u_upload_flush

2011-06-10 Thread Rafael Monica
I cannot test it now, but last time the flush call was removed it caused a major regression on Evergreen. See: https://bugs.freedesktop.org/show_bug.cgi?id=34008 So please do not remove unless there are also no regressions on Evergreen. Thanks. ___ dri

[PATCH] r600g: remove useless call to u_upload_flush

2011-06-10 Thread Pierre-Eric Pelloux-Prayer
u_upload_flush() is called each time r600_flush() is used. There is a comment specifically saying : /* XXX This shouldn't be really necessary, but removing it breaks some tests. * Needless buffer reallocations may significantly increase memory consumption, * so getting