Re: [PATCH] panfrost: Don't cleanup the job if it was successfully queued

2021-09-01 Thread Steven Price
On 31/08/2021 14:35, Boris Brezillon wrote: > The labels are misleading. Even though they are all prefixed with 'fail_' > the success case also takes that path, and we should definitely not > cleanup the job if it's been queued. While at it, let's rename those > labels so we don't do the same mista

Re: [PATCH] panfrost: Don't cleanup the job if it was successfully queued

2021-08-31 Thread Daniel Vetter
On Tue, Aug 31, 2021 at 03:35:56PM +0200, Boris Brezillon wrote: > The labels are misleading. Even though they are all prefixed with 'fail_' > the success case also takes that path, and we should definitely not > cleanup the job if it's been queued. While at it, let's rename those > labels so we do

[PATCH] panfrost: Don't cleanup the job if it was successfully queued

2021-08-31 Thread Boris Brezillon
The labels are misleading. Even though they are all prefixed with 'fail_' the success case also takes that path, and we should definitely not cleanup the job if it's been queued. While at it, let's rename those labels so we don't do the same mistake again. Fixes: 53516280cc38 ("drm/panfrost: use s