Re: [PATCH] nouveau: make backlight support non optional

2021-08-09 Thread Arnd Bergmann
On Mon, Aug 9, 2021 at 3:20 PM Jani Nikula wrote: > > On Sat, 24 Jul 2021, Arnd Bergmann wrote: > > On Sat, Jul 24, 2021 at 4:14 PM Karol Herbst wrote: > >> > >> we use the MXM_WMI in code. We also have to keep arm in mind and not > >> break stuff there. So I will try to play around with your ch

Re: [PATCH] nouveau: make backlight support non optional

2021-08-09 Thread Jani Nikula
On Sat, 24 Jul 2021, Arnd Bergmann wrote: > On Sat, Jul 24, 2021 at 4:14 PM Karol Herbst wrote: >> >> we use the MXM_WMI in code. We also have to keep arm in mind and not >> break stuff there. So I will try to play around with your changes and >> see how that goes. > > Ok, should find any randcon

Re: [PATCH] nouveau: make backlight support non optional

2021-07-24 Thread Arnd Bergmann
On Sat, Jul 24, 2021 at 4:14 PM Karol Herbst wrote: > > we use the MXM_WMI in code. We also have to keep arm in mind and not > break stuff there. So I will try to play around with your changes and > see how that goes. Ok, should find any randconfig build failures for arm, arm64 or x86 over the we

Re: [PATCH] nouveau: make backlight support non optional

2021-07-24 Thread Karol Herbst
On Sat, Jul 24, 2021 at 4:05 PM Arnd Bergmann wrote: > > On Sat, Jul 24, 2021 at 2:52 PM Karol Herbst wrote: > > > > On Sat, Jul 24, 2021 at 2:10 PM Karol Herbst wrote: > > > > > > On Sat, Jul 24, 2021 at 1:56 PM Arnd Bergmann wrote: > > > > > > > > On Sat, Jul 24, 2021 at 11:55 AM Karol Herbst

Re: [PATCH] nouveau: make backlight support non optional

2021-07-24 Thread Arnd Bergmann
On Sat, Jul 24, 2021 at 2:52 PM Karol Herbst wrote: > > On Sat, Jul 24, 2021 at 2:10 PM Karol Herbst wrote: > > > > On Sat, Jul 24, 2021 at 1:56 PM Arnd Bergmann wrote: > > > > > > On Sat, Jul 24, 2021 at 11:55 AM Karol Herbst wrote: > > > > > > - You run into dependency loops that prevent a su

Re: [PATCH] nouveau: make backlight support non optional

2021-07-24 Thread Karol Herbst
On Sat, Jul 24, 2021 at 2:10 PM Karol Herbst wrote: > > On Sat, Jul 24, 2021 at 1:56 PM Arnd Bergmann wrote: > > > > On Sat, Jul 24, 2021 at 11:55 AM Karol Herbst wrote: > > > > > > On Sat, Jul 24, 2021 at 8:55 AM Arnd Bergmann wrote: > > > > > > > > On Sat, Jul 24, 2021 at 12:47 AM Karol Herbs

Re: [PATCH] nouveau: make backlight support non optional

2021-07-24 Thread Karol Herbst
On Sat, Jul 24, 2021 at 1:56 PM Arnd Bergmann wrote: > > On Sat, Jul 24, 2021 at 11:55 AM Karol Herbst wrote: > > > > On Sat, Jul 24, 2021 at 8:55 AM Arnd Bergmann wrote: > > > > > > On Sat, Jul 24, 2021 at 12:47 AM Karol Herbst wrote: > > > > > > > > In the past this only led to compilation is

Re: [PATCH] nouveau: make backlight support non optional

2021-07-24 Thread Arnd Bergmann
On Sat, Jul 24, 2021 at 11:55 AM Karol Herbst wrote: > > On Sat, Jul 24, 2021 at 8:55 AM Arnd Bergmann wrote: > > > > On Sat, Jul 24, 2021 at 12:47 AM Karol Herbst wrote: > > > > > > In the past this only led to compilation issues. Also the small amount of > > > extra .text shouldn't really matt

Re: [PATCH] nouveau: make backlight support non optional

2021-07-24 Thread Karol Herbst
On Sat, Jul 24, 2021 at 8:55 AM Arnd Bergmann wrote: > > On Sat, Jul 24, 2021 at 12:47 AM Karol Herbst wrote: > > > > In the past this only led to compilation issues. Also the small amount of > > extra .text shouldn't really matter compared to the entire nouveau driver > > anyway. > > > > >

Re: [PATCH] nouveau: make backlight support non optional

2021-07-23 Thread Arnd Bergmann
On Sat, Jul 24, 2021 at 12:47 AM Karol Herbst wrote: > > In the past this only led to compilation issues. Also the small amount of > extra .text shouldn't really matter compared to the entire nouveau driver > anyway. > > select DRM_TTM_HELPER > - select BACKLIGHT_CLASS_DEVICE if DRM

[PATCH] nouveau: make backlight support non optional

2021-07-23 Thread Karol Herbst
In the past this only led to compilation issues. Also the small amount of extra .text shouldn't really matter compared to the entire nouveau driver anyway. Cc: Arnd Bergmann Cc: Lyude Paul Cc: Ben Skeggs Cc: Randy Dunlap Cc: Daniel Vetter Cc: nouv...@lists.freedesktop.org Cc: dri-devel@lists.