[PATCH] nouveau/gsp: add three notifier callbacks that we see in normal operation (v2)

2023-12-04 Thread Dave Airlie
Add NULL callbacks for some things GSP calls that we don't handle, but know about so we avoid the logging. v2: Timur suggested allowing null fn. Signed-off-by: Dave Airlie --- drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --gi

Re: [Nouveau] [PATCH] nouveau/gsp: add three notifier callbacks that we see in normal operation

2023-12-04 Thread Timur Tabi
On Tue, 2023-12-05 at 10:01 +1000, Dave Airlie wrote: > The current code prints a message when we get a callback we don't > handle, this silences those, but maybe I should just silence them. How about this: In r535_gsp_msg_recv(): if (ntfy->fn && (ntfy->fn == msg->function)) { ntfy->func

Re: [Nouveau] [PATCH] nouveau/gsp: add three notifier callbacks that we see in normal operation

2023-12-04 Thread Dave Airlie
On Tue, 5 Dec 2023 at 09:07, Timur Tabi wrote: > > On Tue, 2023-12-05 at 08:55 +1000, Dave Airlie wrote: > > +static int > > +r535_gsp_msg_ucode_libos_print(void *priv, u32 fn, void *repv, u32 repc) > > +{ > > + /* work out what we should do here. */ > > + return 0; > > +} > > This is

Re: [Nouveau] [PATCH] nouveau/gsp: add three notifier callbacks that we see in normal operation

2023-12-04 Thread Timur Tabi
On Tue, 2023-12-05 at 08:55 +1000, Dave Airlie wrote: > +static int > +r535_gsp_msg_ucode_libos_print(void *priv, u32 fn, void *repv, u32 repc) > +{ > +   /* work out what we should do here. */ > +   return 0; > +} This is part of my logrm debugfs patch.  It contains the printf log from a

[PATCH] nouveau/gsp: add three notifier callbacks that we see in normal operation

2023-12-04 Thread Dave Airlie
These seem to get called, but it doesn't look like we have to care too much at this point. Signed-off-by: Dave Airlie --- .../gpu/drm/nouveau/nvkm/subdev/gsp/r535.c| 24 ++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/