Re: [PATCH] kernel/panic: Drop unblank_screen call

2022-09-02 Thread Greg Kroah-Hartman
On Thu, Sep 01, 2022 at 09:26:27PM +0200, Daniel Vetter wrote: > On Thu, 1 Sept 2022 at 13:35, Petr Mladek wrote: > > > > On Tue 2022-08-30 16:50:04, Daniel Vetter wrote: > > > console_unblank() does this too (called in both places right after), > > > and with a lot more confidence inspiring appro

Re: [PATCH] kernel/panic: Drop unblank_screen call

2022-09-01 Thread Daniel Vetter
On Thu, 1 Sept 2022 at 13:35, Petr Mladek wrote: > > On Tue 2022-08-30 16:50:04, Daniel Vetter wrote: > > console_unblank() does this too (called in both places right after), > > and with a lot more confidence inspiring approach to locking. > > > > Reconstructing this story is very strange: > > >

Re: [PATCH] kernel/panic: Drop unblank_screen call

2022-08-31 Thread Sebastian Andrzej Siewior
On 2022-08-30 16:50:04 [+0200], Daniel Vetter wrote: > Long story short, I have no idea why the direct call to unblank_screen > survived for so long (the infrastructure to do it properly existed for > years), nor why it wasn't removed when the console_unblank() call was > finally added. But it make

[PATCH] kernel/panic: Drop unblank_screen call

2022-08-30 Thread Daniel Vetter
console_unblank() does this too (called in both places right after), and with a lot more confidence inspiring approach to locking. Reconstructing this story is very strange: In b61312d353da ("oops handling: ensure that any oops is flushed to the mtdoops console") it is claimed that a printk(" ");